From: Florian Weimer <fweimer@redhat.com>
To: rushing27alien--- via Libc-alpha <libc-alpha@sourceware.org>
Cc: rushing27alien@gmail.com
Subject: Re: [PATCH 1/5] Define `am_pm` string
Date: Mon, 07 Aug 2023 15:20:06 +0200 [thread overview]
Message-ID: <87350vf0qh.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230804040608.25464-1-rushing27alien@gmail.com> (rushing27alien's message of "Fri, 4 Aug 2023 11:06:04 +0700")
* rushing27alien:
> From: RushingAlien <rushing27alien@gmail.com>
>
> Current formatting does not define am_pm string, leading to AM and PM
> not being specified in 12 H time format. This change defines the string
> by changing it from an empty string to "AM";"PM".
>
> `date +%r`
> before: 01:23
> after : 01.23 AM
> ---
> localedata/locales/id_ID | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
> index c10306deb7..e306076e8b 100644
> --- a/localedata/locales/id_ID
> +++ b/localedata/locales/id_ID
> @@ -119,7 +119,7 @@ d_t_fmt "%a %d %b %Y %r"
> date_fmt "%a %d %b %Y %r %Z"
> d_fmt "%d//%m//%y"
> t_fmt "%T"
> -am_pm "";""
> +am_pm "AM";"PM"
> t_fmt_ampm ""
> week 7;19971130;1
> END LC_TIME
Would you please add id_ID to the commit subject? Thanks.
Maybe fold together some of the patches, too.
I don't know if we have any Indonesian cultural experts on this list who
could review this. The first-day-of-week change seems correct based on
a quick web search.
Has this already been changed in CLDR?
Thanks,
Florian
prev parent reply other threads:[~2023-08-07 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 4:06 rushing27alien
2023-08-04 4:06 ` [PATCH 2/5] Define time_fmt_ampm, change from an empty string rushing27alien
2023-08-04 4:06 ` [PATCH 3/5] Use 24-hour format for time_fmt rushing27alien
2023-08-04 4:06 ` [PATCH 4/5] Use 24-hour format for d_t_fmt rushing27alien
2023-08-04 4:06 ` [PATCH 5/5] Change first_weekday to monday rushing27alien
2023-08-07 13:20 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87350vf0qh.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=rushing27alien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).