From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DA709385840B for ; Mon, 7 Aug 2023 13:20:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA709385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691414411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=59JOs2MlcDAFG64pzW6kcz1grYvnca967h9j++pWtMU=; b=gpnTwfHxQsS0wx5iMtUHQdEupapty514FSqBmNWeuRpWELYYHSz9jK32Fde5SO23Siv5Y4 1M8KTw/lm3clAxRPpQm+CJ4xjjML+FUaqzpH3IVYSLxb43SFvXsDDMfRg7YoMqdOPB+FlX ZWhikPLH9yGjZSapBdMkO3QUPAE08eY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-388-mvw1JqKCPY-Uw-_CN_3sKQ-1; Mon, 07 Aug 2023 09:20:08 -0400 X-MC-Unique: mvw1JqKCPY-Uw-_CN_3sKQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 457B380602D; Mon, 7 Aug 2023 13:20:08 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCA2D492C13; Mon, 7 Aug 2023 13:20:07 +0000 (UTC) From: Florian Weimer To: rushing27alien--- via Libc-alpha Cc: rushing27alien@gmail.com Subject: Re: [PATCH 1/5] Define `am_pm` string References: <20230804040608.25464-1-rushing27alien@gmail.com> Date: Mon, 07 Aug 2023 15:20:06 +0200 In-Reply-To: <20230804040608.25464-1-rushing27alien@gmail.com> (rushing27alien's message of "Fri, 4 Aug 2023 11:06:04 +0700") Message-ID: <87350vf0qh.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * rushing27alien: > From: RushingAlien > > Current formatting does not define am_pm string, leading to AM and PM > not being specified in 12 H time format. This change defines the string > by changing it from an empty string to "AM";"PM". > > `date +%r` > before: 01:23 > after : 01.23 AM > --- > localedata/locales/id_ID | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID > index c10306deb7..e306076e8b 100644 > --- a/localedata/locales/id_ID > +++ b/localedata/locales/id_ID > @@ -119,7 +119,7 @@ d_t_fmt "%a %d %b %Y %r" > date_fmt "%a %d %b %Y %r %Z" > d_fmt "%d//%m//%y" > t_fmt "%T" > -am_pm "";"" > +am_pm "AM";"PM" > t_fmt_ampm "" > week 7;19971130;1 > END LC_TIME Would you please add id_ID to the commit subject? Thanks. Maybe fold together some of the patches, too. I don't know if we have any Indonesian cultural experts on this list who could review this. The first-day-of-week change seems correct based on a quick web search. Has this already been changed in CLDR? Thanks, Florian