public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] nscd: Do not rebuild getaddrinfo (bug 30709)
Date: Wed, 02 Aug 2023 16:29:16 +0200	[thread overview]
Message-ID: <873511sekj.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <mvm5y5xk1cw.fsf@suse.de> (Andreas Schwab's message of "Wed, 02 Aug 2023 15:41:51 +0200")

* Andreas Schwab:

> On Aug 02 2023, Florian Weimer wrote:
>
>> I think that's handled differently.  First, nscd/aicache.c is not
>> actually layered on top of getaddrinfo.
>
> So getaddrinfo actually has never been called by nscd?

It could be called by a NSS module.  But it's not called directly.

> I wonder why it was included in the first place.

So do I.  The Git history isn't very illuminating.  The layering
wouldn't work anyway because of the ai_flags processing.  I was
wondering whether the __check_pf stuff was supposed to be overriding
something, but I don't see this either (not even in the history).

Thanks,
Florian


  reply	other threads:[~2023-08-02 14:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 14:13 Florian Weimer
2023-08-02 13:16 ` Andreas Schwab
2023-08-02 13:20   ` Florian Weimer
2023-08-02 13:41     ` Andreas Schwab
2023-08-02 14:29       ` Florian Weimer [this message]
2023-08-10 18:07         ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873511sekj.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).