From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D837C3858C41 for ; Thu, 1 Jun 2023 09:21:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D837C3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685611274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wAnIvnu/icBI05QFaxml1sWLAyP6mSJ3KmxahrSYZss=; b=cz70tjRC5DQci3FQ9YmJ6YO9F9aSG46qNNidhLusjPcwfjwiOptJycrXscHkmJyjiOM/06 0oDnIU6Bdlei4EoFZSzl+oeBMlQYJqS/ToGWcthmB53fFoq3CPfEdDtrUSYQgvYkbjIC2W oF2DVyM83yh8tyxu0Xf/QsTr96VxGS4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-368-X7wDG7oDNwCCOYdYS7mW7g-1; Thu, 01 Jun 2023 05:21:11 -0400 X-MC-Unique: X7wDG7oDNwCCOYdYS7mW7g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 13B8C185A794; Thu, 1 Jun 2023 09:21:11 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8052D492B0B; Thu, 1 Jun 2023 09:21:10 +0000 (UTC) From: Florian Weimer To: "Ying Huang" Cc: , Subject: Re: [PATCH v2] MIPS: Sync elf.h from binutils References: <7518d9d2-138b-d58b-6d95-ef5250093bab@oss.cipunited.com> <13e383ba-2d8b-f9b3-7b93-00113f453c51@oss.cipunited.com> Date: Thu, 01 Jun 2023 11:21:08 +0200 In-Reply-To: <13e383ba-2d8b-f9b3-7b93-00113f453c51@oss.cipunited.com> (Ying Huang's message of "Thu, 01 Jun 2023 17:17:20 +0800") Message-ID: <87353btu63.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Ying Huang: > Hi, > >> >/+/* Object attribute tags. */ />/+enum />/+{ />/+ /* 0-3 are generic. */ />/+ />/+ /* > Floating-point ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_FP = 4, />/+ />/+ /* MSA > ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_MSA = 8, />/+}; />/+ />/+/* Object > attribute values. */ />/+enum />/+{ />/+ /* Values defined for Tag_GNU_MIPS_ABI_MSA. */ />/+ > />/+ /* Not tagged or not using any ABIs affected by the differences. */ />/+ > Val_GNU_MIPS_ABI_MSA_ANY = 0, />/+ />/+ /* Using 128-bit MSA. */ />/+ > Val_GNU_MIPS_ABI_MSA_128 = 1, />/+}; / >> Any reason for using enum constants here, and not #define? I understand >> there is other MIPS precedent, but why continue in this direction? >> >> Thanks, >> Florian > > I wish to keep same with binutils. Fine by me. Thanks, Florian