From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CB6F43858C2C for ; Wed, 14 Sep 2022 10:06:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB6F43858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663149972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4yvlVcUDEGPwwP0ZQuJ5JBFKwYpcFM/ELlLIO2LC1ds=; b=hI4oLVGixMVvLhZ+Xi7+AAB7tOXv0As591G+zRpC4XHe7yRd4X/SwF3o+8SbH5Zuxplvkk OboaJmMfJw38wB8Gg99zifgKYG30cIYrWoFmsSswkdWWxo0MjHQxKOk27kVtbGu2skKPxU VyFMu3K8S28NNbagEm29ffeTS7PRcfc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-612-mePhOjM5P4apjkxBaQxxbA-1; Wed, 14 Sep 2022 06:06:11 -0400 X-MC-Unique: mePhOjM5P4apjkxBaQxxbA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E099E811E81; Wed, 14 Sep 2022 10:06:10 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A2502166B26; Wed, 14 Sep 2022 10:06:09 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: Florian Weimer via Libc-alpha Subject: Re: [PATCH 3/3] elf: Extract glibcelf constants from References: <871qspc2gi.fsf@oldenburg.str.redhat.com> <8ffa2d36-7c2a-dc44-a226-edfe3c4314cb@gotplt.org> Date: Wed, 14 Sep 2022 12:06:08 +0200 In-Reply-To: <8ffa2d36-7c2a-dc44-a226-edfe3c4314cb@gotplt.org> (Siddhesh Poyarekar's message of "Tue, 13 Sep 2022 13:34:26 -0400") Message-ID: <8735cue0dr.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Siddhesh Poyarekar: > On 2022-09-05 10:37, Florian Weimer via Libc-alpha wrote: >> * Florian Weimer via Libc-alpha: >> >>> +_register_elf_h(DtALTERA_NIOS2, prefix='DT_ALTERA_NIOS2_', >>> + skip=_dt_skip, parent=Dt) >> The prefix is non-regular here, it should be 'DT_NIOS_2_'. Fixed >> locally. > > Shouldn't it be DT_NIOS2? I don't see DT_NIOS_2 anywhere. Right, I fixed it. The existing consistency checks do not catch this because the constant gets represented as a generic (non-NIOS2) one if the pattern is not correct, and there is no collision for its value. Maybe I should add a check to _register_elf_h that the pattern must match something. Thanks, Florian