From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A4E25385782D for ; Tue, 19 Apr 2022 09:26:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4E25385782D Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-jPLx-17CMAS2W3YyRBNd5A-1; Tue, 19 Apr 2022 05:25:59 -0400 X-MC-Unique: jPLx-17CMAS2W3YyRBNd5A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B39D3C13A0D; Tue, 19 Apr 2022 09:25:59 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B5DD492C14; Tue, 19 Apr 2022 09:25:58 +0000 (UTC) From: Florian Weimer To: Fangrui Song Cc: libc-alpha@sourceware.org, "H . J . Lu" Subject: Re: [PATCH] elf: Remove __libc_init_secure References: <20220418234738.3170499-1-maskray@google.com> Date: Tue, 19 Apr 2022 11:25:56 +0200 In-Reply-To: <20220418234738.3170499-1-maskray@google.com> (Fangrui Song's message of "Mon, 18 Apr 2022 16:47:38 -0700") Message-ID: <8735i95srf.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 09:26:07 -0000 * Fangrui Song: > After 73fc4e28b9464f0e13edc719a5372839970e7ddb, > __libc_enable_secure_decided is always 0 and a statically linked > executable may overwrite __libc_enable_secure with a value not > considering AT_SECURE. > > The __libc_enable_secure has been correctly initialized in _dl_aux_init, > so just remove __libc_enable_secure_decided and __libc_init_secure. > This allows us to remove some linux/i386 functions from > 22b79ed7f413cd980a7af0cf258da5bf82b6d5e5. This causes a build failure on Hurd: /home/bmg/install/compilers/i686-gnu/lib/gcc/i686-glibc-gnu/11.2.1/../../../../i686-glibc-gnu/bin/ld: /home/bmg/build/glibcs/i686-gnu/glibc/libc.a(init-first.o):/home/bmg/src/glibc/csu/../sysdeps/mach/hurd/i386/init-first.c:42: multiple definition of `__libc_enable_secure'; /home/bmg/build/glibcs/i686-gnu/glibc/libc.a(enbl-secure.o):/home/bmg/src/glibc/elf/enbl-secure.c:30: first defined here I think you need to remove the definition from init-first.c. You can also remove the startup_get*id definitions from sysdeps/generic/startup.h because they are unused after these changes. Thanks, Florian