From: Andreas Schwab <schwab@linux-m68k.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v4] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868)
Date: Fri, 04 Mar 2022 16:24:16 +0100 [thread overview]
Message-ID: <8735jxlp0f.fsf@igel.home> (raw)
In-Reply-To: <85c16187-11e4-6723-476f-9933262432cf@linaro.org> (Adhemerval Zanella's message of "Fri, 4 Mar 2022 11:01:21 -0300")
On Mär 04 2022, Adhemerval Zanella wrote:
>>> + test -f $(objpfx)libtracemod$(1).so \
>>> + && mv $(objpfx)libtracemod$(1).so $(objpfx)libtracemod$(1)
>>
>> This will result in a non-zero status if $(objpfx)libtracemod$(1).so
>> doesn't exist, causing the command to fail. It's also not race-free.
>
> Right, but since $(objpfx)libtracemod$(1).so is a prerequisite I don't
> see how the failure will happen. How do you suggest to handle it?
If $(objpfx)libtracemod$(1).so is guaranteed to exist, then you don't
need the test.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2022-03-04 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 12:02 Adhemerval Zanella
2022-03-04 12:43 ` Andreas Schwab
2022-03-04 14:01 ` Adhemerval Zanella
2022-03-04 15:24 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735jxlp0f.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).