From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 7CAD83858D39 for ; Fri, 4 Mar 2022 15:24:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7CAD83858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4K9BTt0lWzz1qyJN; Fri, 4 Mar 2022 16:24:18 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4K9BTt0LJYz1qqkB; Fri, 4 Mar 2022 16:24:18 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 0oU_jF6p5rOZ; Fri, 4 Mar 2022 16:24:17 +0100 (CET) X-Auth-Info: PRSqKdKFU3sgTLeado1hTvULyJ9PV9J9m9p8CWSz1IpvGmScIW3b5Jvk/26Jo7Zw Received: from igel.home (ppp-46-244-178-203.dynamic.mnet-online.de [46.244.178.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 4 Mar 2022 16:24:17 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id B1B562C37BB; Fri, 4 Mar 2022 16:24:16 +0100 (CET) From: Andreas Schwab To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha , Florian Weimer Subject: Re: [PATCH v4] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868) References: <20220304120201.363600-1-adhemerval.zanella@linaro.org> <877d99lwgi.fsf@igel.home> <85c16187-11e4-6723-476f-9933262432cf@linaro.org> X-Yow: Vote for ME -- I'm well-tapered, half-cocked, ill-conceived and TAX-DEFERRED! Date: Fri, 04 Mar 2022 16:24:16 +0100 In-Reply-To: <85c16187-11e4-6723-476f-9933262432cf@linaro.org> (Adhemerval Zanella's message of "Fri, 4 Mar 2022 11:01:21 -0300") Message-ID: <8735jxlp0f.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 15:24:20 -0000 On Mär 04 2022, Adhemerval Zanella wrote: >>> + test -f $(objpfx)libtracemod$(1).so \ >>> + && mv $(objpfx)libtracemod$(1).so $(objpfx)libtracemod$(1) >> >> This will result in a non-zero status if $(objpfx)libtracemod$(1).so >> doesn't exist, causing the command to fail. It's also not race-free. > > Right, but since $(objpfx)libtracemod$(1).so is a prerequisite I don't > see how the failure will happen. How do you suggest to handle it? If $(objpfx)libtracemod$(1).so is guaranteed to exist, then you don't need the test. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."