From: Florian Weimer <fweimer@redhat.com>
To: Tulio Magno Quites Machado Filho via Libc-alpha
<libc-alpha@sourceware.org>
Cc: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Subject: Re: [PATCH] Fix building tst-socket-timestamp-compat on older Linux
Date: Fri, 11 Feb 2022 20:29:07 +0100 [thread overview]
Message-ID: <8735kprym4.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220211191638.324672-1-tuliom@linux.ibm.com> (Tulio Magno Quites Machado Filho via Libc-alpha's message of "Fri, 11 Feb 2022 16:16:38 -0300")
* Tulio Magno Quites Machado Filho via Libc-alpha:
> Work around an error caused by not having SO_TIMESTAMP_NEW,
> SO_TIMESTAMPNS_NEW, SO_TIMESTAMP_OLD and SO_TIMESTAMPNS_OLD defined.
>
> Tested on ppc64le and x86_64 using Linux 4.16 and 4.18.
> ---
> .../sysv/linux/tst-socket-timestamp-compat.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
> index 0ff1a214e6..68b0a0e412 100644
> --- a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
> +++ b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
> @@ -23,6 +23,23 @@
> #include <support/xunistd.h>
> #include <stdbool.h>
>
> +/* The following macros are only available on ABIs that support 32 bit time_t.
> + This test has a runtime check to guarantee it runs only on these ABIs.
> + However, we need to create fake values to guarantee this test is built
> + for all the ABIs. */
Isn't this related to the kernel header version, and not just time32
support?
Thanks,
Florian
next prev parent reply other threads:[~2022-02-11 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 19:16 Tulio Magno Quites Machado Filho
2022-02-11 19:29 ` Florian Weimer [this message]
2022-02-11 21:25 ` Tulio Magno Quites Machado Filho
2022-02-11 21:40 ` Florian Weimer
2022-02-14 13:08 ` Adhemerval Zanella
2022-02-14 13:12 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735kprym4.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).