From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 7DF68385AC28
 for <libc-alpha@sourceware.org>; Thu, 27 Jan 2022 12:15:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7DF68385AC28
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-369-hwug6HatOwiKFoUZwAMTZQ-1; Thu, 27 Jan 2022 07:15:16 -0500
X-MC-Unique: hwug6HatOwiKFoUZwAMTZQ-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBC981934101;
 Thu, 27 Jan 2022 12:15:15 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.8])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id ED4931F2E6;
 Thu, 27 Jan 2022 12:15:14 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [glibc] posix: Add terminal control setting support for
 posix_spawn
References: <20220125180124.B88AC3857C70@sourceware.org>
 <87bkzxpi6q.fsf@oldenburg.str.redhat.com>
 <a1d4308c-54e8-187d-e6ad-d67b6d2122ad@linaro.org>
 <87bkzxo0g2.fsf@oldenburg.str.redhat.com>
 <080dfb07-9a33-4cd2-e745-1e49c99624b4@linaro.org>
Date: Thu, 27 Jan 2022 13:15:13 +0100
In-Reply-To: <080dfb07-9a33-4cd2-e745-1e49c99624b4@linaro.org> (Adhemerval
 Zanella's message of "Thu, 27 Jan 2022 09:02:11 -0300")
Message-ID: <8735l9nzn2.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jan 2022 12:15:19 -0000

* Adhemerval Zanella:

>>>   posix_spawn_file_actions_t actions;
>>>   posix_spawn_file_actions_init (&actions);
>>>   posix_spawn_file_actions_tcsetgrp_np (&actions, tcfd);
>
> In fact I think it should be posix_spawn_file_actions_addtcsetgrp_np
> to follow other file action naming convention.

Yes, that name is better.

Thanks,
Florian