From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 10B5A3858C27 for ; Fri, 24 Dec 2021 18:53:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 10B5A3858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-_zhFgagQMdOxGUXJhFt4Hw-1; Fri, 24 Dec 2021 13:53:47 -0500 X-MC-Unique: _zhFgagQMdOxGUXJhFt4Hw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63488801B0B; Fri, 24 Dec 2021 18:53:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CAC27B03A; Fri, 24 Dec 2021 18:53:44 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v7 16/16] elf: Fix runtime linker auditing on aarch64 (BZ #26643) References: <20211222132712.523295-1-adhemerval.zanella@linaro.org> <20211222132712.523295-17-adhemerval.zanella@linaro.org> Date: Fri, 24 Dec 2021 19:53:42 +0100 In-Reply-To: <20211222132712.523295-17-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 22 Dec 2021 10:27:12 -0300") Message-ID: <8735mh96mh.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Dec 2021 18:53:50 -0000 * Adhemerval Zanella: > The aarch64 rtld audit support is change to: > > * Both La_aarch64_regs and La_aarch64_retval are expanded to include > both x8 and the full sized NEON V registers, as defined by the > ABI. > > * dl_runtime_profile needed to extract registers saved by > _dl_runtime_resolve and put them into the new correctly sized > La_aarch64_regs structure. > > * The LAV_CURRENT check is change to only accept new audit modules > to avoid the undefined behavior of not save/restore x8. I forgot about the x8 issue. The commit message should mention the ABI change as the reason for the LAV_CURRENT enforcement. Old audit modules could start working on new glibc because the x8 bug is fixed unless they actually try to use enter/exit hooks. I'm fine with not enabling this usage scenario (i.e., rejecting old audit modules that could actually work). This should have a NEWS entry, though. Thanks, Florian