From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1E41C3858401 for ; Mon, 8 Nov 2021 13:46:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E41C3858401 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-D3Y_QUSuOfOV0B1u7KHqCA-1; Mon, 08 Nov 2021 08:46:55 -0500 X-MC-Unique: D3Y_QUSuOfOV0B1u7KHqCA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 790CE87D541; Mon, 8 Nov 2021 13:46:54 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 998B760C4A; Mon, 8 Nov 2021 13:46:52 +0000 (UTC) From: Florian Weimer To: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH 1/2] dso-ordering-test.py: Put all sources in one directory [BZ #28550] References: <20211107150727.157003-1-hjl.tools@gmail.com> <20211107150727.157003-2-hjl.tools@gmail.com> Date: Mon, 08 Nov 2021 14:46:50 +0100 In-Reply-To: <20211107150727.157003-2-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Sun, 7 Nov 2021 07:07:26 -0800") Message-ID: <8735o6kbed.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 13:47:00 -0000 * H. J. Lu via Libc-alpha: > Also use a temporary file to generate Makefile fragments for DSO sorting > tests. I don't see this part in the patch? > diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py > index 944ee74052..26497159a0 100644 > --- a/scripts/dso-ordering-test.py > +++ b/scripts/dso-ordering-test.py > @@ -526,9 +526,13 @@ def process_testcase(t): > base_test_name = t.test_name > test_subdir = base_test_name + "-dir" > testpfx = objpfx + test_subdir + "/" > + test_srcdir = "dso-sort-tests-src/" > + testpfx_src = objpfx + test_srcdir > > if not os.path.exists(testpfx): > os.mkdir(testpfx) > + if not os.path.exists(testpfx_src): > + os.mkdir(testpfx_src) > > def find_objs_not_depended_on(t): > objs_not_depended_on = [] > @@ -595,6 +599,11 @@ def process_testcase(t): > # Print out needed Makefile fragments for use in glibc/elf/Makefile. > module_names = "" > for o in test_descr.objs: > + rule = ("$(objpfx)" + test_subdir + "/" + test_name > + + "-" + o + ".os: $(objpfx)" + test_srcdir > + + test_name + "-" + o + ".c\n" > + "\t$(compile.c) $(OUTPUT_OPTION)\n") > + makefile.write (rule); Spurious semicolon at end of line (there are multiple such cases). Why do you put the generated test sources into a separate subdirectory? Thanks, Florian