From: Andreas Schwab <schwab@linux-m68k.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] regex: fix buffer read overrun in search [BZ#28470]
Date: Tue, 19 Oct 2021 09:17:59 +0200 [thread overview]
Message-ID: <8735oxsct4.fsf@igel.home> (raw)
In-Reply-To: <20211018221548.76024-1-eggert@cs.ucla.edu> (Paul Eggert's message of "Mon, 18 Oct 2021 15:15:48 -0700")
On Okt 18 2021, Paul Eggert wrote:
> /* If MATCH_FIRST is out of the buffer, leave it as '\0'.
> Note that MATCH_FIRST must not be smaller than 0. */
> - ch = (match_first >= length
> + ch = (mctx.input.valid_len <= offset
That needs to update the comment.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-10-19 7:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 22:15 Paul Eggert
2021-10-19 7:17 ` Andreas Schwab [this message]
2021-10-19 8:13 ` Paul Eggert
2021-10-19 8:25 ` Andreas Schwab
2021-10-19 8:57 ` Paul Eggert
2021-10-19 15:09 ` Andreas Schwab
2021-10-19 18:14 ` Paul Eggert
2021-11-24 22:27 ` Paul Eggert
2021-11-24 22:45 ` Andreas Schwab
2021-11-24 23:50 ` Paul Eggert
2021-11-25 9:01 ` Andreas Schwab
2021-11-26 18:35 ` Paul Eggert
2021-11-26 18:39 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735oxsct4.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).