From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 52DCE3858C27 for ; Thu, 26 Aug 2021 10:03:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52DCE3858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-xIQ-oSusMVWn11CxC_o4Og-1; Thu, 26 Aug 2021 06:03:57 -0400 X-MC-Unique: xIQ-oSusMVWn11CxC_o4Og-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F362F801A92; Thu, 26 Aug 2021 10:03:56 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2622A60877; Thu, 26 Aug 2021 10:03:55 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 08/19] nptl: pthread_kill, pthread_cancel should fail after exit (bug 19193) References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-9-adhemerval.zanella@linaro.org> Date: Thu, 26 Aug 2021 12:03:54 +0200 In-Reply-To: <20210823195047.543237-9-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 23 Aug 2021 16:50:36 -0300") Message-ID: <8735qw8qut.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 10:04:04 -0000 * Adhemerval Zanella: > From: Florian Weimer > > This closes one remaining race condition related to bug 12889: if > the thread already exited on the kernel side, returning ESRCH > is not correct because that error is reserved for the thread IDs > (pthread_t values) whose lifetime has ended. In case of a > kernel-side exit and a valid thread ID, no signal needs to be sent > and cancellation does not have an effect, so just return 0. > > sysdeps/pthread/tst-kill4.c triggers undefined behavior and is > removed with this commit. Wrong commit subject: =E2=80=9Cshould [not] fail=E2=80=9D Thanks, Florian