From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org, dj@redhat.com, carlos@redhat.com
Subject: Re: [PATCH v5 1/8] Move malloc hooks into a compat DSO
Date: Tue, 06 Jul 2021 12:17:17 +0200 [thread overview]
Message-ID: <8735sriw5u.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210705170814.4132997-2-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Mon, 5 Jul 2021 22:38:07 +0530")
* Siddhesh Poyarekar:
> Remove all malloc hook uses from core malloc functions and move it
> into a new library libc_malloc_debug.so. With this, the hooks now no
> longer have any effect on the core library.
There are still a few references to libmalloc_compathooks.
> diff --git a/elf/Makefile b/elf/Makefile
> index 698a6ab985..b432e78d39 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -156,7 +156,7 @@ $(inst_auditdir)/sotruss-lib.so: $(objpfx)sotruss-lib.so $(+force)
> @@ -1561,7 +1558,8 @@ $(objpfx)tst-nodelete-dlclose.out: $(objpfx)tst-nodelete-dlclose-dso.so \
> $(objpfx)tst-nodelete-dlclose-plugin.so
>
> tst-env-setuid-ENV = MALLOC_CHECK_=2 MALLOC_MMAP_THRESHOLD_=4096 \
> - LD_HWCAP_MASK=0x1
> + LD_HWCAP_MASK=0x1 \
> + LD_PRELOAD=$(common-objpfx)/malloc/libc_malloc_debug.so
I don't think this test needs the debugging allocator, it uses getenv to
see if the environment has been scrubbed.
In general, it looks like it's time to add support for mtrace tests to
the setsuite (that is, tests-mtrace like tests-time64).
Thanks,
Florian
next prev parent reply other threads:[~2021-07-06 10:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 17:08 [PATCH v5 0/8] malloc hooks removal Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 1/8] Move malloc hooks into a compat DSO Siddhesh Poyarekar
2021-07-06 10:17 ` Florian Weimer [this message]
2021-07-06 13:00 ` Siddhesh Poyarekar
2021-07-06 13:12 ` Siddhesh Poyarekar
2021-07-06 14:29 ` Florian Weimer
2021-07-06 14:40 ` Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 2/8] mcheck: Wean away from malloc hooks Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 3/8] Simplify __malloc_initialized Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 4/8] mtrace: Wean away from malloc hooks Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 5/8] glibc.malloc.check: " Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 6/8] Remove " Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 7/8] Remove __after_morecore_hook Siddhesh Poyarekar
2021-07-05 17:08 ` [PATCH v5 8/8] Remove __morecore and __default_morecore Siddhesh Poyarekar
2021-07-06 19:45 ` [PATCH v5 0/8] malloc hooks removal DJ Delorie
2021-07-07 1:31 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735sriw5u.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).