From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E953B383602A for ; Tue, 6 Jul 2021 10:17:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E953B383602A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-rrUv2K5qNVeS4X--DhDRXQ-1; Tue, 06 Jul 2021 06:17:24 -0400 X-MC-Unique: rrUv2K5qNVeS4X--DhDRXQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25E3E1800D41; Tue, 6 Jul 2021 10:17:23 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCA3760CC6; Tue, 6 Jul 2021 10:17:19 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org, dj@redhat.com, carlos@redhat.com Subject: Re: [PATCH v5 1/8] Move malloc hooks into a compat DSO References: <20210705170814.4132997-1-siddhesh@sourceware.org> <20210705170814.4132997-2-siddhesh@sourceware.org> Date: Tue, 06 Jul 2021 12:17:17 +0200 In-Reply-To: <20210705170814.4132997-2-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Mon, 5 Jul 2021 22:38:07 +0530") Message-ID: <8735sriw5u.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 10:17:28 -0000 * Siddhesh Poyarekar: > Remove all malloc hook uses from core malloc functions and move it > into a new library libc_malloc_debug.so. With this, the hooks now no > longer have any effect on the core library. There are still a few references to libmalloc_compathooks. > diff --git a/elf/Makefile b/elf/Makefile > index 698a6ab985..b432e78d39 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -156,7 +156,7 @@ $(inst_auditdir)/sotruss-lib.so: $(objpfx)sotruss-lib.so $(+force) > @@ -1561,7 +1558,8 @@ $(objpfx)tst-nodelete-dlclose.out: $(objpfx)tst-nodelete-dlclose-dso.so \ > $(objpfx)tst-nodelete-dlclose-plugin.so > > tst-env-setuid-ENV = MALLOC_CHECK_=2 MALLOC_MMAP_THRESHOLD_=4096 \ > - LD_HWCAP_MASK=0x1 > + LD_HWCAP_MASK=0x1 \ > + LD_PRELOAD=$(common-objpfx)/malloc/libc_malloc_debug.so I don't think this test needs the debugging allocator, it uses getenv to see if the environment has been scrubbed. In general, it looks like it's time to add support for mtrace tests to the setsuite (that is, tests-mtrace like tests-time64). Thanks, Florian