From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 69B553836C5C for ; Tue, 22 Dec 2020 12:00:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 69B553836C5C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-c3wSmbPeNIuECCygpl9TuQ-1; Tue, 22 Dec 2020 07:00:45 -0500 X-MC-Unique: c3wSmbPeNIuECCygpl9TuQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4672F1005513; Tue, 22 Dec 2020 12:00:44 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-120.ams2.redhat.com [10.36.112.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8DA2860C64; Tue, 22 Dec 2020 12:00:43 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 3/3] posix: Add posix_spawn_file_actions_closefrom References: <20201221215027.2176966-1-adhemerval.zanella@linaro.org> <20201221215027.2176966-3-adhemerval.zanella@linaro.org> <87ft3yulcy.fsf@oldenburg2.str.redhat.com> Date: Tue, 22 Dec 2020 13:00:41 +0100 In-Reply-To: (Adhemerval Zanella's message of "Tue, 22 Dec 2020 08:56:31 -0300") Message-ID: <8735zyuk2e.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 12:00:49 -0000 * Adhemerval Zanella: >>> diff --git a/posix/spawn.h b/posix/spawn.h >>> index be6bd591a3..21ea563425 100644 >>> --- a/posix/spawn.h >>> +++ b/posix/spawn.h >>> @@ -213,6 +213,13 @@ extern int posix_spawn_file_actions_addchdir_np (posix_spawn_file_actions_t * >>> extern int posix_spawn_file_actions_addfchdir_np (posix_spawn_file_actions_t *, >>> int __fd) >>> __THROW __nonnull ((1)); >>> + >>> +/* Add an action to close all file descriptor greater than FROM during >>> + spawn. This affects the subsequent file actions. */ >>> +extern int posix_spawn_file_actions_addclosefrom_np (posix_spawn_file_actions_t *, >>> + int __from) >>> + __THROW __nonnull ((1)); >>> + >>> #endif >> >> Line length issue (but I'm not sure how to avoid that). > > Maybe move the argument to next line aligning with __THROW? > > extern int posix_spawn_file_actions_addclosefrom_np ( > posix_spawn_file_actions_t *, int __from) > __THROW __nonnull ((1)); > > ? I think it's not GNU style. You could drop the extern, though. >> You could simplify the reinvocation logic by making this a static or a >> container test. > > I prefer to keep this exercises this test on some platform where container > tests are not really supported. Then perhaps make it a static test, or only make it a container test for the non-hard-coded-paths case? >>> diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c >>> index f157bfffd2..f496578d19 100644 >>> --- a/sysdeps/unix/sysv/linux/spawni.c >>> +++ b/sysdeps/unix/sysv/linux/spawni.c >>> @@ -16,22 +16,17 @@ >>> License along with the GNU C Library; if not, see >>> . */ >>> >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include >>> +#include >>> +#include >>> +#include >>> #include >>> +#include >>> +#include >>> #include >>> -#include >>> -#include >>> -#include >>> -#include >>> -#include "spawn_int.h" >>> +#include >>> +#include >>> +#include >>> +#include >> >> Suprious changes? > > In fact I cleanup the include range a bit, if you prefer I can remove this > change from this set. Hmm. I think is not used here? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill