From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D5E463857804 for ; Thu, 15 Oct 2020 10:35:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5E463857804 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-tOYGuSAnONGb7soCBPqI3A-1; Thu, 15 Oct 2020 06:35:53 -0400 X-MC-Unique: tOYGuSAnONGb7soCBPqI3A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D0C2804002; Thu, 15 Oct 2020 10:35:52 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-145.ams2.redhat.com [10.36.114.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA73676666; Thu, 15 Oct 2020 10:35:51 +0000 (UTC) From: Florian Weimer To: Stefan Liebler via Libc-alpha Cc: Stefan Liebler Subject: Re: [PATCH 3/3] resolv: Handle transaction ID collisions in parallel queries (bug 26600) References: <55f9a2d387df8fae7d44275e2cf7dce8eccd120e.1599829382.git.fweimer@redhat.com> <87lfhgqx9u.fsf@oldenburg2.str.redhat.com> <180cdf95-e0cc-8c0d-1594-06a35a2012be@linux.ibm.com> <87k0vsk7w0.fsf@oldenburg2.str.redhat.com> Date: Thu, 15 Oct 2020 12:35:50 +0200 In-Reply-To: <87k0vsk7w0.fsf@oldenburg2.str.redhat.com> (Florian Weimer's message of "Wed, 14 Oct 2020 19:57:35 +0200") Message-ID: <87362fixo9.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2020 10:35:57 -0000 * Florian Weimer: > This should fix the crash at least, it's a concurrency bug in the test: > > diff --git a/resolv/tst-resolv-txnid-collision.c b/resolv/tst-resolv-txnid-collision.c > index 611d3736..db9a52b6 100644 > --- a/resolv/tst-resolv-txnid-collision.c > +++ b/resolv/tst-resolv-txnid-collision.c > @@ -309,6 +309,7 @@ do_test (void) > ((struct resolv_redirect_config) > { > .response_callback = response, > + .single_thread_udp = true, > }); > > for (int rcode = 0; rcode <= 5; ++rcode) > > I doubt it will fix the other test failure, but I'm going to run the > test over night with this test. My tests over night looked good, and the above change is clearly needed, so I have pushed that as commit b8b53b338f6da91e86d115a39da860cefac736ad. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill