From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 841C538708B8 for ; Tue, 13 Oct 2020 10:14:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 841C538708B8 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-129-Ydou3YKpPJ2YzgnBxUHWXA-1; Tue, 13 Oct 2020 06:14:36 -0400 X-MC-Unique: Ydou3YKpPJ2YzgnBxUHWXA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA17E87507D for ; Tue, 13 Oct 2020 10:14:35 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-237.ams2.redhat.com [10.36.114.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A7D85C1C2 for ; Tue, 13 Oct 2020 10:14:35 +0000 (UTC) From: Florian Weimer To: Florian Weimer via Libc-alpha Subject: Re: [PATCH 3/3] resolv: Handle transaction ID collisions in parallel queries (bug 26600) References: <55f9a2d387df8fae7d44275e2cf7dce8eccd120e.1599829382.git.fweimer@redhat.com> <87lfhgqx9u.fsf@oldenburg2.str.redhat.com> Date: Tue, 13 Oct 2020 12:14:33 +0200 In-Reply-To: <87lfhgqx9u.fsf@oldenburg2.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Fri, 11 Sep 2020 15:05:17 +0200") Message-ID: <87362iwhyu.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2020 10:14:41 -0000 * Florian Weimer via Libc-alpha: > If the transaction IDs are equal, the old check attributed both > responses to the first query, not recognizing the second response. > This fixes bug 26600. > > (Tested on x86_64-linux-gnu. I verified that the referral path for > RCODE 0 responses is taken. I also linked tst-resolv-txnid-collision.o > against an ABI-compatible static glibc build without the fix, to verify > that the test reproduces the bug.) Ping. These patches need review: Apparently, users encounter this bug quite frequently on s390x with certain applications. Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill