From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C448B3851C2B for ; Thu, 8 Oct 2020 13:37:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C448B3851C2B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-iA1FaU2ZN-eOHN94d01DGw-1; Thu, 08 Oct 2020 09:37:32 -0400 X-MC-Unique: iA1FaU2ZN-eOHN94d01DGw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 930731062748; Thu, 8 Oct 2020 13:37:14 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0E26100238C; Thu, 8 Oct 2020 13:37:13 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 08/28] elf: Implement ld.so --version References: <7333a9c583135f6660716d67c05da78a65df0aea.1601569371.git.fweimer@redhat.com> <0622aa62-11bd-eff2-3966-e7753a5f04f0@linaro.org> Date: Thu, 08 Oct 2020 15:37:12 +0200 In-Reply-To: <0622aa62-11bd-eff2-3966-e7753a5f04f0@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 7 Oct 2020 15:36:00 -0300") Message-ID: <87362og7p3.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 13:37:37 -0000 * Adhemerval Zanella via Libc-alpha: > Maybe _Noreturn here? Fixed. >> +void >> +_dl_version (void) >> +{ >> + _dl_printf ("\ >> +ld.so " PKGVERSION RELEASE " release version " VERSION ".\n\ >> +Copyright (C) 2020 Free Software Foundation, Inc.\n\ >> +This is free software; see the source for copying conditions.\n\ >> +There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A\n\ >> +PARTICULAR PURPOSE.\n\ >> +"); >> + _exit (0); >> +} Also switched to EXIT_SUCCESS here. Pushed with these changes based on your later comment: > And I just noted you are handling on the scripts/update-copyrights, > so this should be ok. > > Reviewed-by: Adhemerval Zanella Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill