From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 7A21C3857C61 for ; Thu, 1 Oct 2020 08:46:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7A21C3857C61 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-AIhKUOzsP_K-g1TzOYstzg-1; Thu, 01 Oct 2020 04:46:13 -0400 X-MC-Unique: AIhKUOzsP_K-g1TzOYstzg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E559C10BBEDE; Thu, 1 Oct 2020 08:46:12 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-84.ams2.redhat.com [10.36.114.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33EAB60BF1; Thu, 1 Oct 2020 08:46:12 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: "H.J. Lu via Libc-alpha" Subject: Re: V3 [PATCH] x86: Initialize CPU info via IFUNC relocation [BZ 26203] References: <20200918160709.949608-1-hjl.tools@gmail.com> <20200918160709.949608-2-hjl.tools@gmail.com> <87imby6obw.fsf@oldenburg2.str.redhat.com> <87y2ku574k.fsf@oldenburg2.str.redhat.com> <87lfgu56c8.fsf@oldenburg2.str.redhat.com> <87pn663qm5.fsf@oldenburg2.str.redhat.com> <87ft71yq64.fsf@oldenburg2.str.redhat.com> Date: Thu, 01 Oct 2020 10:46:10 +0200 In-Reply-To: (H. J. Lu's message of "Tue, 29 Sep 2020 04:44:50 -0700") Message-ID: <87362yl4fh.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 08:46:31 -0000 * H. J. Lu: > diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c > index dadec5d58f..65ab29123d 100644 > --- a/sysdeps/x86/cacheinfo.c > +++ b/sysdeps/x86/cacheinfo.c > @@ -16,7 +16,9 @@ > License along with the GNU C Library; if not, see > . */ > =20 > -#if IS_IN (libc) > +/* NB: In libc.a, this file is included in libc-static.c. In libc.so, > + this file is standalone. */ > +#if IS_IN (libc) && (defined SHARED || defined _PRIVATE_CPU_FEATURES_H) libc-static.c should be libc-start.c, I believe. The =E2=80=9Cdefined _PRIVATE_CPU_FEATURES_H=E2=80=9D part seems rather indirect. What exactly = are you trying to accomplish here? It looks to me as if this file should included in libc.so, but not pulled into ld.so via the rebuild, so maybe you can add an empty sysdeps/x86/rtld-cacheinfo.c file instead? Thanks, Florian --=20 Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'N= eill