From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id D22C8386EC3F for ; Tue, 29 Sep 2020 13:01:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D22C8386EC3F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-92dazI-mPZOH1-owI3nxFA-1; Tue, 29 Sep 2020 09:01:28 -0400 X-MC-Unique: 92dazI-mPZOH1-owI3nxFA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 580A21054F8E; Tue, 29 Sep 2020 13:01:26 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-84.ams2.redhat.com [10.36.114.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D38FD5D9CA; Tue, 29 Sep 2020 13:01:24 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha , Robert O'Callahan , "Dmitry V . Levin" Subject: Re: [PATCH 3/6] sysvipc: Fix IPC_INFO and MSG_INFO handling [BZ #26639] References: <20200928144556.239160-1-adhemerval.zanella@linaro.org> <20200928144556.239160-3-adhemerval.zanella@linaro.org> <87blhpyq09.fsf@oldenburg2.str.redhat.com> <1b71983c-db12-a6ff-692d-1ab3bd784758@linaro.org> Date: Tue, 29 Sep 2020 15:01:23 +0200 In-Reply-To: (Adhemerval Zanella's message of "Tue, 29 Sep 2020 09:58:36 -0300") Message-ID: <873630ybx8.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2020 13:01:34 -0000 * Adhemerval Zanella: > On 29/09/2020 09:37, Adhemerval Zanella wrote: >> >> >> On 29/09/2020 04:57, Florian Weimer wrote: >>> * Adhemerval Zanella via Libc-alpha: >>> >>>> +static int >>>> +read_proc_file (const char *file) >>>> +{ >>>> + FILE *f = fopen (file, "r"); >>>> + if (f == NULL) >>>> + return -1; >>>> + >>>> + int v; >>>> + int r = fscanf (f, "%d", & v); >>>> + TEST_VERIFY_EXIT (r == 1); >>>> + >>>> + fclose (f); >>>> + return v; >>>> +} >>> >>> You could use xfopen and xfclose. >> >> Indeed, I will change it. > > In fact I though about it before and for this test we do want to > check if the /proc file is accessible and just check against the > tunable value if it were the case. Otherwise the test will always > fail if /proc is not mounted (not really the expected scenario I > give you). Maybe add FAIL_UNSUPPORTED for this case at the start of the test? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill