From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: GT <tnggil@protonmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v0] PPC64: Attach SIMD attribute to cosf, sin, sinf function declarations.
Date: Thu, 13 Feb 2020 19:27:00 -0000 [thread overview]
Message-ID: <8736bethj7.fsf@linux.ibm.com> (raw)
In-Reply-To: <DvwHcak5KwVvbzMv_WCM7H9nJszCKQQ4SdW02ubyAj4LgcjJqDglQd8h9nDtibqBr1GO5JXfAfQJaWaHBS8FTGcz8d8Yu7pjFgLgszxBhvI=@protonmail.com>
GT <tnggil@protonmail.com> writes:
> This is the first of 2 patches required to enable GCC auto-vectorization
> of calls to libmvec.
>
> The changes here should have been part of earlier patches to libmvec
> which added SIMD versions of the functions.
>
> There are a few other small patches in tuliom/libmvec that should
> similarly have been part of earlier patches. Can we re-organize the
> patches in tuliom/libmvec using git rebase before submitting them for
> inclusion in master?
Could you be more specific, please?
What kind of reorganization are you suggesting?
> Subject: [PATCH v0] PPC64: Attach SIMD attribute to cosf, sin, sinf function
> declarations.
>
> These changes were mistakenly left out of the patches that added SIMD
> versions of these functions to libmvec.
This patch is not just adding missing data, it's also moving lines around.
Some of them seem to be re-sorted, but not all of them.
> diff --git a/sysdeps/powerpc/bits/math-vector.h b/sysdeps/powerpc/bits/math-vector.h
> index ce10dc4bb7..66651b02f3 100644
> --- a/sysdeps/powerpc/bits/math-vector.h
> +++ b/sysdeps/powerpc/bits/math-vector.h
> @@ -36,22 +36,28 @@
> # ifdef __DECL_SIMD_PPC64
> # undef __DECL_SIMD_cos
> # define __DECL_SIMD_cos __DECL_SIMD_PPC64
> -# undef __DECL_SIMD_log
> -# define __DECL_SIMD_log __DECL_SIMD_PPC64
> -# undef __DECL_SIMD_logf
> -# define __DECL_SIMD_logf __DECL_SIMD_PPC64
> +# undef __DECL_SIMD_cosf
> +# define __DECL_SIMD_cosf __DECL_SIMD_PPC64
> +# undef __DECL_SIMD_sin
> +# define __DECL_SIMD_sin __DECL_SIMD_PPC64
> +# undef __DECL_SIMD_sinf
> +# define __DECL_SIMD_sinf __DECL_SIMD_PPC64
> # undef __DECL_SIMD_sincos
> # define __DECL_SIMD_sincos __DECL_SIMD_PPC64
> # undef __DECL_SIMD_sincosf
> # define __DECL_SIMD_sincosf __DECL_SIMD_PPC64
> -# undef __DECL_SIMD_expf
> -# define __DECL_SIMD_expf __DECL_SIMD_PPC64
Why are these 2 lines moving to...
> +# undef __DECL_SIMD_log
> +# define __DECL_SIMD_log __DECL_SIMD_PPC64
> +# undef __DECL_SIMD_logf
> +# define __DECL_SIMD_logf __DECL_SIMD_PPC64
> # undef __DECL_SIMD_exp
> # define __DECL_SIMD_exp __DECL_SIMD_PPC64
> -# undef __DECL_SIMD_powf
> -# define __DECL_SIMD_powf __DECL_SIMD_PPC64
> +# undef __DECL_SIMD_expf
> +# define __DECL_SIMD_expf __DECL_SIMD_PPC64
... here?
--
Tulio Magno
next prev parent reply other threads:[~2020-02-13 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 18:43 GT
2020-02-13 19:27 ` Tulio Magno Quites Machado Filho [this message]
2020-02-13 19:56 ` GT
2020-02-13 20:19 ` Tulio Magno Quites Machado Filho
2020-02-13 21:00 ` GT
2020-02-19 18:32 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736bethj7.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=libc-alpha@sourceware.org \
--cc=tnggil@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).