From: Florian Weimer <fweimer@redhat.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: libc-alpha@sourceware.org, zatrazz@gmail.com, carlos@redhat.com
Subject: Re: [PATCH v1] linux: Add support for getrandom vDSO
Date: Tue, 30 Jul 2024 22:16:09 +0200 [thread overview]
Message-ID: <874j86zldi.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20240730132440.1181819-1-Jason@zx2c4.com> (Jason A. Donenfeld's message of "Tue, 30 Jul 2024 15:24:40 +0200")
* Jason A. Donenfeld:
> This is joint work with Adhemerval. We've been iterating on this in
> parallel with the kernel development, and now that the kernel part has
> landed, we're ready to submit the glibc implementation here.
I find the fork handling part puzzling. This needs comments. I expect
that we need to reset the state pointer in threads that do not exist.
The vgetrandom_get_state function does not look async-signal-safe, and
safe against concurrent fork (given that its lock is just
reinitialized). It's on the slow path, so maybe it could block signals.
It seems wrong that __getrandom_nocancel uses SYSCALL_CANCEL.
Thanks,
Florian
next prev parent reply other threads:[~2024-07-30 20:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 13:24 Jason A. Donenfeld
2024-07-30 20:16 ` Florian Weimer [this message]
2024-07-31 12:38 ` Adhemerval Zanella Netto
2024-08-01 1:47 ` Jason A. Donenfeld
2024-08-01 2:11 ` [PATCH v2] " Jason A. Donenfeld
2024-08-01 6:47 ` Florian Weimer
2024-08-19 19:35 ` Adhemerval Zanella Netto
2024-08-20 4:13 ` Jason A. Donenfeld
2024-08-02 17:32 ` [PATCH v1] " Cristian Rodríguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j86zldi.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=Jason@zx2c4.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=zatrazz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).