* [PATCH] nptl: Make tst-tls3mod.so explicitly lazy
@ 2023-07-19 19:24 Arsen Arsenović
2023-07-20 7:23 ` Florian Weimer
0 siblings, 1 reply; 5+ messages in thread
From: Arsen Arsenović @ 2023-07-19 19:24 UTC (permalink / raw)
To: libc-alpha; +Cc: Arsen Arsenović
Fixes the following test-time errors, that lead to FAILs, on toolchains
that set -z now out o the box, such as the one used on Gentoo Hardened:
.../build-x86-x86_64-pc-linux-gnu-nptl $ grep '' nptl/tst-tls3*.out
nptl/tst-tls3.out:dlopen failed
nptl/tst-tls3-malloc.out:dlopen failed
---
Hi,
I've been testing glibc in preparation for 2.38 and spotted two more
test failures caused by a lack of -z lazy, similar to those fixed by
6c7388d0b95ef9ae39fbe6f733e2c5049769c4f9.
This patch fixes those FAILs.
Have a lovely day!
nptl/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/nptl/Makefile b/nptl/Makefile
index f8365467d9..ffa5722e48 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -636,6 +636,7 @@ $(objpfx)tst-cleanup4: $(objpfx)tst-cleanup4aux.o
$(objpfx)tst-cleanupx4: $(objpfx)tst-cleanupx4aux.o
LDFLAGS-tst-tls3 = -rdynamic
+LDFLAGS-tst-tls3mod.so = -Wl,-z,lazy
$(objpfx)tst-tls3.out: $(objpfx)tst-tls3mod.so
LDFLAGS-tst-tls3-malloc = -rdynamic
--
2.41.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nptl: Make tst-tls3mod.so explicitly lazy
2023-07-19 19:24 [PATCH] nptl: Make tst-tls3mod.so explicitly lazy Arsen Arsenović
@ 2023-07-20 7:23 ` Florian Weimer
2023-07-20 8:04 ` Arsen Arsenović
0 siblings, 1 reply; 5+ messages in thread
From: Florian Weimer @ 2023-07-20 7:23 UTC (permalink / raw)
To: Arsen Arsenović via Libc-alpha; +Cc: Arsen Arsenović
* Arsen Arsenović via Libc-alpha:
> Fixes the following test-time errors, that lead to FAILs, on toolchains
> that set -z now out o the box, such as the one used on Gentoo Hardened:
>
> .../build-x86-x86_64-pc-linux-gnu-nptl $ grep '' nptl/tst-tls3*.out
> nptl/tst-tls3.out:dlopen failed
> nptl/tst-tls3-malloc.out:dlopen failed
> ---
> Hi,
>
> I've been testing glibc in preparation for 2.38 and spotted two more
> test failures caused by a lack of -z lazy, similar to those fixed by
> 6c7388d0b95ef9ae39fbe6f733e2c5049769c4f9.
>
> This patch fixes those FAILs.
>
> Have a lovely day!
>
> nptl/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/nptl/Makefile b/nptl/Makefile
> index f8365467d9..ffa5722e48 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -636,6 +636,7 @@ $(objpfx)tst-cleanup4: $(objpfx)tst-cleanup4aux.o
> $(objpfx)tst-cleanupx4: $(objpfx)tst-cleanupx4aux.o
>
> LDFLAGS-tst-tls3 = -rdynamic
> +LDFLAGS-tst-tls3mod.so = -Wl,-z,lazy
> $(objpfx)tst-tls3.out: $(objpfx)tst-tls3mod.so
>
> LDFLAGS-tst-tls3-malloc = -rdynamic
Looks reasonable. Can you apply this yourself?
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nptl: Make tst-tls3mod.so explicitly lazy
2023-07-20 7:23 ` Florian Weimer
@ 2023-07-20 8:04 ` Arsen Arsenović
2023-07-20 10:25 ` committed (was: Re: [PATCH] nptl: Make tst-tls3mod.so explicitly lazy) Andreas K. Huettel
0 siblings, 1 reply; 5+ messages in thread
From: Arsen Arsenović @ 2023-07-20 8:04 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
Florian Weimer <fweimer@redhat.com> writes:
> * Arsen Arsenović via Libc-alpha:
> [...snip...]
>
> Looks reasonable. Can you apply this yourself?
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
>
> Thanks,
> Florian
No, I do not have write rights currently.
Thanks for the review, have a lovely day.
--
Arsen Arsenović
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* committed (was: Re: [PATCH] nptl: Make tst-tls3mod.so explicitly lazy)
2023-07-20 8:04 ` Arsen Arsenović
@ 2023-07-20 10:25 ` Andreas K. Huettel
0 siblings, 0 replies; 5+ messages in thread
From: Andreas K. Huettel @ 2023-07-20 10:25 UTC (permalink / raw)
To: Florian Weimer, libc-alpha; +Cc: libc-alpha, Arsen Arsenović
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
Am Donnerstag, 20. Juli 2023, 10:04:01 CEST schrieb Arsen Arsenović via Libc-alpha:
>
> Florian Weimer <fweimer@redhat.com> writes:
>
> > * Arsen Arsenović via Libc-alpha:
> > [...snip...]
> >
> > Looks reasonable. Can you apply this yourself?
> >
> > Reviewed-by: Florian Weimer <fweimer@redhat.com>
> >
> > Thanks,
> > Florian
>
> No, I do not have write rights currently.
>
> Thanks for the review, have a lovely day.
>
Pushed, thanks!
--
PD Dr. Andreas K. Huettel
Institute for Experimental and Applied Physics
University of Regensburg
93040 Regensburg
Germany
tel. +49 151 241 67748 (mobile)
tel. +49 941 943 1618 (office)
e-mail andreas.huettel@ur.de
https://www.akhuettel.de/
https://www.akhuettel.de/group/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 981 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] nptl: Make tst-tls3mod.so explicitly lazy
@ 2023-07-19 18:45 Arsen Arsenović
0 siblings, 0 replies; 5+ messages in thread
From: Arsen Arsenović @ 2023-07-19 18:45 UTC (permalink / raw)
To: libc-alpha; +Cc: Arsen Arsenović
From: Arsen Arsenović <arsen@gentoo.org>
Fixes the following test-time errors, that lead to FAILs, on toolchains
that set -z now out of the box, such as the one used on Gentoo Hardened:
.../build-x86-x86_64-pc-linux-gnu-nptl $ grep '' nptl/tst-tls3*.out
nptl/tst-tls3.out:dlopen failed
nptl/tst-tls3-malloc.out:dlopen failed
---
Hi,
I've been testing glibc in preparation for 2.38 and spotted two more
test failures caused by a lack of -z lazy, similar to those fixed by
6c7388d0b95ef9ae39fbe6f733e2c5049769c4f9.
This patch fixes those FAILs.
Have a lovely day!
nptl/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/nptl/Makefile b/nptl/Makefile
index f8365467d9..ffa5722e48 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -636,6 +636,7 @@ $(objpfx)tst-cleanup4: $(objpfx)tst-cleanup4aux.o
$(objpfx)tst-cleanupx4: $(objpfx)tst-cleanupx4aux.o
LDFLAGS-tst-tls3 = -rdynamic
+LDFLAGS-tst-tls3mod.so = -Wl,-z,lazy
$(objpfx)tst-tls3.out: $(objpfx)tst-tls3mod.so
LDFLAGS-tst-tls3-malloc = -rdynamic
--
2.41.0
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-20 10:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-19 19:24 [PATCH] nptl: Make tst-tls3mod.so explicitly lazy Arsen Arsenović
2023-07-20 7:23 ` Florian Weimer
2023-07-20 8:04 ` Arsen Arsenović
2023-07-20 10:25 ` committed (was: Re: [PATCH] nptl: Make tst-tls3mod.so explicitly lazy) Andreas K. Huettel
-- strict thread matches above, loose matches on Subject: below --
2023-07-19 18:45 [PATCH] nptl: Make tst-tls3mod.so explicitly lazy Arsen Arsenović
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).