From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=HoVE=CO=redhat.com=fweimer@sourceware.org>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.145.221.124])
	by sourceware.org (Postfix) with ESMTPS id 58B423858D20
	for <libc-alpha@sourceware.org>; Mon, 26 Jun 2023 13:59:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58B423858D20
Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1687787945;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RljTKOsel6AThdGLwkAfMfWljWnd4/LxvD6nrwds6GQ=;
	b=I2Zn70oJmwIvTMYRxxmHW0XCuntG7ZCII5uscU8XhKNjdVifKu0/rml13T0uax8nzYMBFA
	2alzWxj8OvWdkCV4UhkMXLYQ1v/6HNfNjK7+SX7fZmMhRR/mbKwAkBmBaPUWVPKMLSL99S
	Eq4zZzDrumln1aZyFypeLhzU/DY8KdU=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-2-o04z2QedNxaa6FtEgDT_Og-1; Mon, 26 Jun 2023 09:59:02 -0400
X-MC-Unique: o04z2QedNxaa6FtEgDT_Og-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1493858EED;
	Mon, 26 Jun 2023 13:59:01 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 25AAA400F54;
	Mon, 26 Jun 2023 13:59:01 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: =?utf-8?B?0L3QsNCx?= <nabijaczleweli@nabijaczleweli.xyz>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 3/2] statvfs: f_type: NEWS & test
References: <87cz1i74b2.fsf@oldenburg.str.redhat.com>
	<nlbgowoon2rcgb76nod3elhsvczmrit7t7ul2mbf36h7xdfo5w@ckpcvznp6g6l>
Date: Mon, 26 Jun 2023 15:58:59 +0200
In-Reply-To: <nlbgowoon2rcgb76nod3elhsvczmrit7t7ul2mbf36h7xdfo5w@ckpcvznp6g6l>
	(=?utf-8?B?ItC90LDQsSIncw==?= message of "Mon, 26 Jun 2023 15:50:09 +0200")
Message-ID: <874jmu5nq4.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* =D0=BD=D0=B0=D0=B1:

>  /* This test cannot detect many errors.  But it will fail if the
> @@ -11,17 +13,18 @@ do_test (int argc, char *argv[])
>    for (int i =3D 1; i < argc; ++i)
>      {
>        struct statvfs st;
> -      if (statvfs (argv[i], &st) !=3D 0)
> -        printf ("%s: failed (%m)\n", argv[i]);
> -      else
> -        printf ("%s: free: %llu, mandatory: %s\n", argv[i],
> -                (unsigned long long int) st.f_bfree,
> +      struct statfs stf;
> +      TEST_VERIFY (statvfs (argv[i], &st) =3D=3D 0);
> +      TEST_VERIFY (statfs (argv[i], &stf) =3D=3D 0);
> +      TEST_VERIFY (st.f_type =3D=3D stf.f_type);

These TEST_VERIFYs could use TEST_COMPARE for better diagnostics on
failure.

Thanks,
Florian