From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
	by sourceware.org (Postfix) with ESMTPS id A1CF23858409
	for <libc-alpha@sourceware.org>; Mon,  7 Nov 2022 13:22:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1CF23858409
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1667827357;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9Wy4nPADdQLcahRrTqlzk+NR0kZ4cJW1mLcwbXlgBQU=;
	b=bWM0wTpzffO/FBELuywIO83Q9jIb8cqUGAIn+bPNC6XrfuBBjFVDdq6xB2di2JuRISZuBW
	iEvKB/hSvcvWQFtl2U3nYU8+WiVkk4HriUlbf6LKdJduEwzocMQjOEfKf7UYG0NKrMCAaC
	U3ZXgpvF8JKj2khdqQH1XFCzIo4yaCU=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-175-VqURfD2iMPOJ8baIw9yTRA-1; Mon, 07 Nov 2022 08:22:34 -0500
X-MC-Unique: VqURfD2iMPOJ8baIw9yTRA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ACEBA186E393;
	Mon,  7 Nov 2022 13:22:33 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.2.16.86])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A3AB042222;
	Mon,  7 Nov 2022 13:22:32 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Fangrui Song <maskray@google.com>,  Adhemerval Zanella
 <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH v2 2/4] Rewrite find_cxx_header config configure.ac
References: <20221102145559.1962008-1-adhemerval.zanella@linaro.org>
	<20221102145559.1962008-3-adhemerval.zanella@linaro.org>
Date: Mon, 07 Nov 2022 14:22:30 +0100
In-Reply-To: <20221102145559.1962008-3-adhemerval.zanella@linaro.org>
	(Adhemerval Zanella via Libc-alpha's message of "Wed, 2 Nov 2022
	11:55:57 -0300")
Message-ID: <874jvakig9.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

* Adhemerval Zanella via Libc-alpha:

> diff --git a/configure b/configure
> index fc3d7842de..e23ea95a49 100755
> --- a/configure
> +++ b/configure
> @@ -5669,8 +5669,8 @@ fi
>  # copy of those headers in Makerules.
>  if test -n "$CXX"; then
>    find_cxx_header () {
> -    echo "#include <$1>" | $CXX -M -MP -x c++ - 2>/dev/null \
> -	 | sed -n "\,$1:,{s/:\$//;p}"
> +    echo "#include <$1>" | $CXX -H -fsyntax-only -x c++ - 2>&1 \
> +	 | awk '$1 == "."{print $2}'
>    }
>    CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)"
>    CXX_CMATH_HEADER="$(find_cxx_header cmath)"

Shouldn't this use $ac_cv_prog_AWK?

Thanks,
Florian