From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1BF293858D28 for ; Mon, 25 Apr 2022 21:06:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BF293858D28 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-668-_SAwlqN0N4uCnmejlj4dPg-1; Mon, 25 Apr 2022 17:06:40 -0400 X-MC-Unique: _SAwlqN0N4uCnmejlj4dPg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A18E3C14102; Mon, 25 Apr 2022 21:06:29 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39C3840149A6; Mon, 25 Apr 2022 21:06:26 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH] scripts/glibcelf.py: Mark as UNSUPPORTED on Python 3.5 and earlier References: <875yn1rpdy.fsf@oldenburg.str.redhat.com> <87fsm1r5ry.fsf@oldenburg.str.redhat.com> Date: Mon, 25 Apr 2022 23:06:23 +0200 In-Reply-To: (Adhemerval Zanella via Libc-alpha's message of "Mon, 25 Apr 2022 14:21:10 -0300") Message-ID: <874k2gna9c.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 21:06:44 -0000 * Adhemerval Zanella via Libc-alpha: > On 25/04/2022 04:17, Florian Weimer via Libc-alpha wrote: >> * Florian Weimer: >> >>> enum.IntFlag and enum.EnumMeta._missing_ support is not present in those >>> Python versions. >>> >>> --- >>> scripts/glibcelf.py | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/scripts/glibcelf.py b/scripts/glibcelf.py >>> index 8f7d0ca184..da0d5380f3 100644 >>> --- a/scripts/glibcelf.py >>> +++ b/scripts/glibcelf.py >>> @@ -28,6 +28,12 @@ import collections >>> import enum >>> import struct >>> >>> +if not hasattr(enum, 'IntFlag'): >>> + import sys >>> + sys.stdout.write( >>> + 'warning: glibcelf.py needs Python 3.6 for enum support\n') >>> + sys.exit(77) >>> + >>> class _OpenIntEnum(enum.IntEnum): >>> """Integer enumeration that supports arbitrary int values.""" >>> @classmethod >> >> I've pushed this, to avoid masking other failures in Joseph's tester. > > We still indicate that Python 3.4 is supported on INSTALL. I think we > should either update it or add a fallback code on glibcelf.py. Tests using scripts/glibcelf.py are marked as UNSUPPORTED. Isn't this sufficient for now? We can say that Python 3.6 or later is recommended for full test coverage. Thanks, Florian