From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 2A473385E013
 for <libc-alpha@sourceware.org>; Tue, 25 Jan 2022 21:47:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A473385E013
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-601-POhUawl0OG6HrnfoC8rIIA-1; Tue, 25 Jan 2022 16:47:40 -0500
X-MC-Unique: POhUawl0OG6HrnfoC8rIIA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C673B100C618;
 Tue, 25 Jan 2022 21:47:39 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.8])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id BBCBDCB843;
 Tue, 25 Jan 2022 21:47:34 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 4/5] avoid -Wuse-after-free [BZ #26779]
References: <c9f4a1b4-193e-986c-bc21-5866b9e62e16@gmail.com>
 <53f20975-a2c9-674d-2a43-b1b323ee545c@gmail.com>
 <05e683bb-96d7-ebff-b0e1-f988e261b19b@gmail.com>
 <d1737316-9be6-dbf4-6564-6d6ad7740b43@redhat.com>
 <2f541755-b177-9c5a-3237-51946e96fcce@redhat.com>
Date: Tue, 25 Jan 2022 22:47:32 +0100
In-Reply-To: <2f541755-b177-9c5a-3237-51946e96fcce@redhat.com> (Carlos
 O'Donell via Libc-alpha's message of "Tue, 25 Jan 2022 12:51:17
 -0500")
Message-ID: <874k5rwkqz.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jan 2022 21:47:45 -0000

* Carlos O'Donell via Libc-alpha:

> Should be:
> ~~~
> stdlib: Avoid -Wuse-after-free [BZ #26779]
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ~~~

Shouldn't the commit subject mention __add_to_environ (or maybe setenv)?

Thanks,
Florian