From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BB0F0385780A for ; Fri, 21 Jan 2022 10:50:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB0F0385780A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-354-V548Z3mCNaW5gsUWhd436A-1; Fri, 21 Jan 2022 05:50:41 -0500 X-MC-Unique: V548Z3mCNaW5gsUWhd436A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 094C2192AB6D; Fri, 21 Jan 2022 10:50:40 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98E3D73162; Fri, 21 Jan 2022 10:50:38 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: jma14 , Carlos O'Donell , Adhemerval Zanella , John Mellor-Crummey Subject: Re: [PATCH v10 1/4] elf: Add la_activity during application exit References: <20220117213136.1327053-1-adhemerval.zanella@linaro.org> <20220117213136.1327053-2-adhemerval.zanella@linaro.org> Date: Fri, 21 Jan 2022 11:50:36 +0100 In-Reply-To: <20220117213136.1327053-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 17 Jan 2022 18:31:33 -0300") Message-ID: <874k5x8irn.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2022 10:50:45 -0000 * Adhemerval Zanella via Libc-alpha: > +static int > +do_test (int argc, char *argv[]) > +{ > + /* We must have either: > + - One our fource parameters left if called initially: > + + path to ld.so optional > + + "--library-path" optional > + + the library path optional > + + the application name */ > + if (restart) > + return handle_restart (); > + > + char *spargv[9]; > + int i = 0; > + for (; i < argc - 1; i++) > + spargv[i] = argv[i + 1]; > + spargv[i++] = (char *) "--direct"; > + spargv[i++] = (char *) "--restart"; > + spargv[i] = NULL; Please add a check for an out-of-range argc value, or allocate the array on the heap. > + while (xgetline (&buffer, &buffer_length, out)) > + { > + if (startswith (buffer, "la_activity: ")) > + { > + uintptr_t cookie; > + int this_act; > + int r = sscanf (buffer + strlen ("la_activity: "), > + "%d %"SCNxPTR"", &this_act, &cookie); > + TEST_COMPARE (r, 2); I wonder if you can fold the startswith check into the sscanf. At least you could put "la_activity: " into the format string. Thanks, Florian