From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id B30D53858415
 for <libc-alpha@sourceware.org>; Tue,  7 Sep 2021 07:24:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B30D53858415
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-447-ej2r1ijcPVuCJiDpSn1HAQ-1; Tue, 07 Sep 2021 03:24:48 -0400
X-MC-Unique: ej2r1ijcPVuCJiDpSn1HAQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EF8FC19611A1;
 Tue,  7 Sep 2021 07:24:46 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.195.4])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id DDAFD5D6CF;
 Tue,  7 Sep 2021 07:24:45 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Stafford Horne via Libc-alpha <libc-alpha@sourceware.org>
Cc: Stafford Horne <shorne@gmail.com>, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v2] time: Fix compile error in itimer test affecting hurd
References: <20210819212800.455725-1-shorne@gmail.com>
Date: Tue, 07 Sep 2021 09:24:43 +0200
In-Reply-To: <20210819212800.455725-1-shorne@gmail.com> (Stafford Horne via
 Libc-alpha's message of "Fri, 20 Aug 2021 06:28:00 +0900")
Message-ID: <874kawx2ys.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Sep 2021 07:25:01 -0000

* Stafford Horne via Libc-alpha:

> +/* Return true if the setitimer and getitimer syscalls support 64-bit time_t
> +   values without resulting in overflow.  This is not true on some linux systems
> +   which have 64-bit time_t due to legacy kernel API's.  */
> +static __inline bool support_itimer_support_time64 (void)
> +{
> +#ifdef __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64
> +  return __KERNEL_OLD_TIMEVAL_MATCHES_TIMEVAL64;
> +#else
> +  return (sizeof (__time_t) == 8);
> +#endif
> +}

Extra parentheses for the second return.  I haven't followed development
in this area and I'm not sure if that's following the direction others
prefer.  I'd say wait a few more days for comments, and if there are
none, commit with the parentheses removed.

Thanks,
Florian