From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id B97D03853833 for ; Thu, 17 Jun 2021 12:19:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B97D03853833 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-CLcDgbwZMiemm2WIeCn0dg-1; Thu, 17 Jun 2021 08:19:49 -0400 X-MC-Unique: CLcDgbwZMiemm2WIeCn0dg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A158801106; Thu, 17 Jun 2021 12:19:48 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A66C19D61; Thu, 17 Jun 2021 12:19:46 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 02/35] Fix librt-routines-var issues for !PTHREAD_IN_LIBC References: Date: Thu, 17 Jun 2021 14:19:44 +0200 In-Reply-To: (Adhemerval Zanella's message of "Thu, 17 Jun 2021 08:07:01 -0300") Message-ID: <874kdw7kf3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 12:19:51 -0000 * Adhemerval Zanella: > On 03/06/2021 20:14, Florian Weimer via Libc-alpha wrote: >> The variable name was incorrect, and the existing librt-routines >> variable needs to be augmented (not assigned) in rt/Makefile. > > LGTM, thanks. Is this cause any build issue? I am curious why we haven't > see it before. It's relevant to the subsequent changes. librt-routines-var wasn't really used before. > Reviewed-by: Adhemerval Zanella Thanks, Florian