From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id F04C638515EB for ; Wed, 9 Jun 2021 18:27:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F04C638515EB Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-GRCElVUqN0u6f4OheTJJwA-1; Wed, 09 Jun 2021 14:27:17 -0400 X-MC-Unique: GRCElVUqN0u6f4OheTJJwA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37EF2192D785; Wed, 9 Jun 2021 18:27:16 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04398620DE; Wed, 9 Jun 2021 18:27:14 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar via Libc-alpha Cc: Adhemerval Zanella , Siddhesh Poyarekar , schwab@linux-m68k.org Subject: Re: [PATCH] Handle DT_UNKNOWN in gconv-modules.d References: <20210609043835.218509-1-siddhesh@sourceware.org> <637d9c58-610a-e68f-b743-85c99e18be1d@sourceware.org> Date: Wed, 09 Jun 2021 20:27:13 +0200 In-Reply-To: <637d9c58-610a-e68f-b743-85c99e18be1d@sourceware.org> (Siddhesh Poyarekar via Libc-alpha's message of "Wed, 9 Jun 2021 23:38:16 +0530") Message-ID: <874ke651xa.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 18:27:19 -0000 * Siddhesh Poyarekar via Libc-alpha: >> But I think we should move away from alloca, even when we know it >> is bounded (sorry if I didn't catch on the previous patch). For >> this specific usage we can use asprintf to create the path or use >> a static PATH_MAX buffer. > > I agree, a static PATH_MAX makes sense, I'll do that. PATH_MAX is not available on Hurd. Thanks, Florian