From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A37D5395C81B for ; Wed, 2 Jun 2021 14:37:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A37D5395C81B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-UrO9-9hWPZ2_37u50ypD_w-1; Wed, 02 Jun 2021 10:37:40 -0400 X-MC-Unique: UrO9-9hWPZ2_37u50ypD_w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9D178015C6; Wed, 2 Jun 2021 14:37:38 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com [10.36.113.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF49A19714; Wed, 2 Jun 2021 14:37:37 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 09/16] dlfcn: Move dlmopen into libc References: <59a14fc491a58520936da8d69093abf9112a7ffe.1622469908.git.fweimer@redhat.com> <477ae2c4-40ef-a74a-1150-6761b1c7099a@linaro.org> Date: Wed, 02 Jun 2021 16:37:35 +0200 In-Reply-To: <477ae2c4-40ef-a74a-1150-6761b1c7099a@linaro.org> (Adhemerval Zanella's message of "Wed, 2 Jun 2021 11:19:05 -0300") Message-ID: <874kegz61c.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 14:37:52 -0000 * Adhemerval Zanella: > On 31/05/2021 11:12, Florian Weimer via Libc-alpha wrote: >> The symbol was moved using scripts/move-symbol-to-libc.py. > > LGTM, thanks. I would move the compat symbols at dlfcn/dlfcn.c to > a dlfcn/libdl-compat.c, similar to what is done for libpthread. I'm going to rename the file in the final cleanup patch, where dlfcn/dlfcn.c is otherwise empty. Thanks, Florian