From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id A89EE385800A
 for <libc-alpha@sourceware.org>; Thu, 25 Mar 2021 13:46:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A89EE385800A
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (port=33839 helo=deneb.enyo.de)
 by albireo.enyo.de ([172.17.140.2]) with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1lPQJP-0001F0-5g; Thu, 25 Mar 2021 13:46:11 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1lPQJP-0002If-2q; Thu, 25 Mar 2021 14:46:11 +0100
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 04/14] nptl: Remove open from libpthread
References: <20210319202914.2475530-1-adhemerval.zanella@linaro.org>
 <20210319202914.2475530-5-adhemerval.zanella@linaro.org>
Date: Thu, 25 Mar 2021 14:46:11 +0100
In-Reply-To: <20210319202914.2475530-5-adhemerval.zanella@linaro.org>
 (Adhemerval Zanella via Libc-alpha's message of "Fri, 19 Mar 2021
 17:29:04 -0300")
Message-ID: <874kgzny70.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Mar 2021 13:46:13 -0000

* Adhemerval Zanella via Libc-alpha:

> diff --git a/sysdeps/mach/hurd/i386/ld.abilist b/sysdeps/mach/hurd/i386/ld.abilist
> index 7e20c5e7ce..a2a16523b5 100644
> --- a/sysdeps/mach/hurd/i386/ld.abilist
> +++ b/sysdeps/mach/hurd/i386/ld.abilist
> @@ -3,8 +3,6 @@ GLIBC_2.2.6 __errno_location F
>  GLIBC_2.2.6 __getpid F
>  GLIBC_2.2.6 __libc_stack_end D 0x4
>  GLIBC_2.2.6 __mmap F
> -GLIBC_2.2.6 __open F
> -GLIBC_2.2.6 __open64 F
>  GLIBC_2.2.6 __pread64 F
>  GLIBC_2.2.6 __read F
>  GLIBC_2.2.6 __sbrk F

This change seems unintended.  It causes elf/check-abi-ld to fail on
i686-gnu.

If you drop this part, I think the patch is okay.