From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7CF143858D33 for ; Mon, 15 Mar 2021 13:42:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7CF143858D33 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-W_tg6GGqOlC7Ur00UTdAwA-1; Mon, 15 Mar 2021 09:42:03 -0400 X-MC-Unique: W_tg6GGqOlC7Ur00UTdAwA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4805E760C7; Mon, 15 Mar 2021 13:42:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-163.ams2.redhat.com [10.36.112.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D6AB5D705; Mon, 15 Mar 2021 13:42:01 +0000 (UTC) From: Florian Weimer To: Carlos Eduardo Seo via Libc-alpha Subject: Re: [RFC] Fix static-only build of glibc [BZ #20845] References: <20210309205916.74906-1-carlos.seo@linaro.org> Date: Mon, 15 Mar 2021 14:42:07 +0100 In-Reply-To: <20210309205916.74906-1-carlos.seo@linaro.org> (Carlos Eduardo Seo via Libc-alpha's message of "Tue, 9 Mar 2021 17:59:16 -0300") Message-ID: <874khcv8i8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, LIKELY_SPAM_BODY, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 13:42:06 -0000 * Carlos Eduardo Seo via Libc-alpha: > The following patch fixes the build when configuring with '--disable-shared'. > > However, a second phase for properly fixing this will be required, as > the tests need to be triaged (i.e. what should be running and what > should not when building with --disable-shared). My proposal is to > first fix the build (this patch) and then start looking at the tests > and fixing those in subsequent patches. Does that sound reasonable? Could you split this up by root cause, and mention them in the commit message? Some parts are easy to review, others, not so. And for the latter category, it would help to have some rationale for the change. Thanks, Florian