Re: [PATCH 6/6] nptl: Move elision implementations into libc

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella:

>> +/* Automatically enable elision for existing user lock kinds.  */
>> +# define FORCE_ELISION(m, s)                                            \
>> +  if (__pthread_force_elision)                                          \
>> +    {                                                                   \

>> +      if ((mutex_kind & PTHREAD_MUTEX_ELISION_NP) != 0)                 \
>> +        {                                                               \
>> +          s;                                                            \
>> +        }                                                               \
>> +    }
>
> Maybe since you are refactoring it, to use a static inline instead of macro
> here?

That's not possible due to the way the s parameter is used.

>> diff --git a/sysdeps/unix/sysv/linux/powerpc/pthread_mutex_timedlock.c b/sysdeps/pthread/elision-conf.h
>> similarity index 64%
>> rename from sysdeps/unix/sysv/linux/powerpc/pthread_mutex_timedlock.c
>> rename to sysdeps/pthread/elision-conf.h
>> index 6f8b06d459..6635a7c56f 100644

>> +/* No elision support by default.  */
>> +#define HAVE_ELISION 0
>
> Maybe prepend the define with a string related to code it relates to,
> like 'ELISION_CONF_'? This links the define more directly to the
> implementation, since HAVE_* is usually defined by config.h.

Like ENABLE_ELISION_SUPPORT instead of HAVE_ELISION?  Fine.  I just
reused what was there.

The elision-conf.h file name is also not 100% appropriate given those
two defines.

Thanks for the review.

Florian