From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dormouse.elm.relay.mailchannels.net (dormouse.elm.relay.mailchannels.net [23.83.212.50]) by sourceware.org (Postfix) with ESMTPS id 08E46385780B for ; Thu, 19 Nov 2020 19:54:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 08E46385780B X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7A21C7013CE; Thu, 19 Nov 2020 19:54:02 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-22-162.trex.outbound.svc.cluster.local [100.96.22.162]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 75AD6701113; Thu, 19 Nov 2020 19:54:01 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from pdx1-sub0-mail-a18.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.10); Thu, 19 Nov 2020 19:54:02 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Exultant-Trail: 2dce10b427958ac8_1605815641771_4259734136 X-MC-Loop-Signature: 1605815641771:3107102559 X-MC-Ingress-Time: 1605815641771 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id 2D38080079; Thu, 19 Nov 2020 11:54:01 -0800 (PST) Received: from ascii.art.br (unknown [168.195.65.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tuliom@ascii.art.br) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 6E6C37F103; Thu, 19 Nov 2020 11:54:00 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a18 From: Tulio Magno Quites Machado Filho To: "Paul E. Murphy" , libc-alpha@sourceware.org Subject: Re: [PATCHv5] powerpc64le: ifunc select *f128 routines in multiarch mode In-Reply-To: <20201102152742.97585-1-murphyp@linux.ibm.com> References: <20201102152742.97585-1-murphyp@linux.ibm.com> User-Agent: Notmuch/0.29.1 (http://notmuchmail.org) Emacs/26.3 (x86_64-redhat-linux-gnu) Date: Thu, 19 Nov 2020 16:53:57 -0300 Message-ID: <874klldsx6.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 19:54:05 -0000 "Paul E. Murphy via Libc-alpha" writes: > Programatically generate simple wrappers for interesting libm *f128 > objects. Selected functions are transcendental functions or > those with trivial compiler builtins. This can result in a 2-3x > speedup (e.g logf128 and expf128). > > A second set of implementation files are generated which include > the first implementation encountered along the search path. This > usually works, except when a wrapper is overriden and makefile > search order slightly diverges from include order. Likewise, > wrapper object files are created for each generated file. These > hold the ifunc selection routines which export ABI. > > Next, several shared headers are intercepted to control renaming of > asm function redirects are used first, and sometimes macro renames > if the former is impractical. > > Notably, if the request machine supports hardware IEEE128 (i.e POWER9 > and newer) this ifunc machinery is disabled. Likewise existing > ifunc support for float128 is consolidated into this (e.g sqrtf128 > and fmaf128). LGTM Reviewed-by: Tulio Magno Quites Machado Filho Thanks! -- Tulio Magno