From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 432C8385783A for ; Fri, 9 Oct 2020 08:19:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 432C8385783A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-hsQxZqtTNeerzqLuX2Tr0w-1; Fri, 09 Oct 2020 04:18:59 -0400 X-MC-Unique: hsQxZqtTNeerzqLuX2Tr0w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8BC1464144; Fri, 9 Oct 2020 08:18:58 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D75FC50B44; Fri, 9 Oct 2020 08:18:57 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 14/28] elf: Enhance ld.so --help to print HWCAP subdirectories References: <0df1f307-c122-7ba2-9c3c-14bec8d506c4@linaro.org> Date: Fri, 09 Oct 2020 10:18:56 +0200 In-Reply-To: <0df1f307-c122-7ba2-9c3c-14bec8d506c4@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 8 Oct 2020 13:27:24 -0300") Message-ID: <874kn3errj.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 08:19:03 -0000 * Adhemerval Zanella via Libc-alpha: > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella Thanks. >> + const char *platform = GLRO (dl_platform); >> + if (platform != NULL) >> + _dl_printf (" %s (AT_PLATFORM)\n", platform); I'm going to change this to (AT_PLATFORM; supported, searched) for consistency with the other lines. >> + >> + _dl_printf (" tls (supported, searched)\n"); >> + >> + uint64_t hwcap_mask = GET_HWCAP_MASK(); >> + uint64_t searched = GLRO (dl_hwcap) & hwcap_mask; >> + for (int n = 63; n >= 0; --n) >> + { >> + uint64_t bit = 1ULL << n; > > UINT64_C(1) maybe? unsigned long long needs to be at least 64 bits in our environment, so I think this should be fine. Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill