From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id 7073A3858D34
 for <libc-alpha@sourceware.org>; Wed, 22 Apr 2020 15:06:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7073A3858D34
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1jRGwu-0001wx-0v; Wed, 22 Apr 2020 15:06:04 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1jRGwt-00063Z-UA; Wed, 22 Apr 2020 17:06:03 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: "Paul E. Murphy via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] float128: use builtin_signbitf128 always
References: <20200407212702.24301-1-murphyp@linux.vnet.ibm.com>
Date: Wed, 22 Apr 2020 17:06:03 +0200
In-Reply-To: <20200407212702.24301-1-murphyp@linux.vnet.ibm.com> (Paul
 E. Murphy via Libc-alpha's message of "Tue, 7 Apr 2020 16:27:02
 -0500")
Message-ID: <874ktbk1b8.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2020 15:06:06 -0000

* Paul E. Murphy via Libc-alpha:

> The previous patch failed to account for the now unneeded
> hidden_proto which mangles the symbol name in the shared
> libary variants.
>
> Also, fixup my email to use IBM IMAP email.
>
> Tested on x86-64.

Also tested on i686-linux-gnu and built on a few float128 targets.

Is there anyone else more qualified who wants to review this?  I you
think you should commit & push this.