From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] signal: Use <sigsetops.h> for sigemptyset, sigfillset
Date: Wed, 22 Apr 2020 14:14:00 +0200 [thread overview]
Message-ID: <874ktblnuf.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <11e55091-7bd1-e079-cdec-0b58ebb1b3ff@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 22 Apr 2020 08:47:51 -0300")
* Adhemerval Zanella via Libc-alpha:
> On 22/04/2020 07:02, Florian Weimer wrote:
>> * Florian Weimer:
>>
>>> * Andreas Schwab:
>>>
>>>> On Apr 22 2020, Florian Weimer wrote:
>>>>
>>>>> * Andreas Schwab:
>>>>>
>>>>>> On Apr 22 2020, Florian Weimer wrote:
>>>>>>
>>>>>>> This avoids changing the entire sigset_t structure. Updating the
>>>>>>> actually used part is sufficient.
>>>>>>
>>>>>> I'm not sure it's a good idea to leave most of the structure
>>>>>> uninitialized.
>>>>>
>>>>> Would you please elaborate? How is this different from padding?
>>>>
>>>> Padding is always unnamed.
>>>
>>> Not if it is called __glibc_reserved. I obviously meant named
>>> padding.
>>
>> And sigprocmask has always left the padding uninitialized (even before
>> Adhemerval's changes).
>
> Should we change __sigemptyset/__sigfillset to fill the ununsed bits
> instead?
We would have to change sigprocmask as well.
next prev parent reply other threads:[~2020-04-22 12:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 8:27 Florian Weimer
2020-04-22 8:37 ` Andreas Schwab
2020-04-22 8:39 ` Florian Weimer
2020-04-22 9:40 ` Andreas Schwab
2020-04-22 9:44 ` Florian Weimer
2020-04-22 10:02 ` Florian Weimer
2020-04-22 11:47 ` Adhemerval Zanella
2020-04-22 12:14 ` Florian Weimer [this message]
2020-04-22 12:22 ` Florian Weimer
2020-04-22 13:23 ` Adhemerval Zanella
2020-04-28 13:13 ` Florian Weimer
2020-04-28 10:48 ` Florian Weimer
2020-04-28 12:55 ` Adhemerval Zanella
2020-05-08 16:34 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ktblnuf.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).