* [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
@ 2019-01-10 0:17 Andreas K. Hüttel
2019-01-10 11:01 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Andreas K. Hüttel @ 2019-01-10 0:17 UTC (permalink / raw)
To: libc-alpha; +Cc: Andreas K. Hüttel
The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling
output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
Turns out the switch statement is missing a break, so the "T_AAAA" case
continues with "default".
---
resolv/tst-resolv-ai_idn-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c
index bb81c2ca23..61cc81b71f 100644
--- a/resolv/tst-resolv-ai_idn-common.c
+++ b/resolv/tst-resolv-ai_idn-common.c
@@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx,
qname[0] };
resolv_response_add_data (b, &addr, sizeof (addr));
}
+ break;
default:
FAIL_EXIT1 ("invalid qtype: %d", qtype);
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
2019-01-10 0:17 [PATCH] resolv: AAAA (28) is valid, no fallthrough to default Andreas K. Hüttel
@ 2019-01-10 11:01 ` Florian Weimer
2019-01-10 13:47 ` Andreas K. Huettel
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2019-01-10 11:01 UTC (permalink / raw)
To: Andreas K. Hüttel; +Cc: libc-alpha
* Andreas K. Hüttel:
> The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling
> output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
> Turns out the switch statement is missing a break, so the "T_AAAA" case
> continues with "default".
> ---
> resolv/tst-resolv-ai_idn-common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c
> index bb81c2ca23..61cc81b71f 100644
> --- a/resolv/tst-resolv-ai_idn-common.c
> +++ b/resolv/tst-resolv-ai_idn-common.c
> @@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx,
> qname[0] };
> resolv_response_add_data (b, &addr, sizeof (addr));
> }
> + break;
> default:
> FAIL_EXIT1 ("invalid qtype: %d", qtype);
> }
The change is obviously correct. I will commit it for you.
However, how do you encounter this issue? Did you change some test?
The current IDN tests do not actually send AAAA queries, I think.
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
2019-01-10 11:01 ` Florian Weimer
@ 2019-01-10 13:47 ` Andreas K. Huettel
2019-01-10 13:51 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Andreas K. Huettel @ 2019-01-10 13:47 UTC (permalink / raw)
To: libc-alpha; +Cc: Florian Weimer
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
Am Donnerstag, 10. Januar 2019, 12:00:08 CET schrieb Florian Weimer:
> * Andreas K. Hüttel:
> > The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the
> > puzzling
> > output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
> > Turns out the switch statement is missing a break, so the "T_AAAA" case
> > continues with "default".
>
> The change is obviously correct. I will commit it for you.
>
> However, how do you encounter this issue? Did you change some test?
> The current IDN tests do not actually send AAAA queries, I think.
>
> Thanks,
> Florian
That's a puzzling question indeed. I didnt change anything with the test
suite; the code is ~ tip of 2.28 release branch (plus few Gentoo-specific
patches).
The only Gentoo-specific commit which could be relevant is that we revert
8479f23aa1d5e5477a37f46823856bdafaedfa46 ("sysdeps/posix/getaddrinfo.c
(gaih_inet): Only use gethostbyname4_r ..."). For the background see
https://bugs.gentoo.org/600632
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
2019-01-10 13:47 ` Andreas K. Huettel
@ 2019-01-10 13:51 ` Florian Weimer
0 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer @ 2019-01-10 13:51 UTC (permalink / raw)
To: Andreas K. Huettel; +Cc: libc-alpha
* Andreas K. Huettel:
> Am Donnerstag, 10. Januar 2019, 12:00:08 CET schrieb Florian Weimer:
>> * Andreas K. Hüttel:
>> > The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the
>> > puzzling
>> > output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
>> > Turns out the switch statement is missing a break, so the "T_AAAA" case
>> > continues with "default".
>>
>> The change is obviously correct. I will commit it for you.
>>
>> However, how do you encounter this issue? Did you change some test?
>> The current IDN tests do not actually send AAAA queries, I think.
>>
>> Thanks,
>> Florian
>
> That's a puzzling question indeed. I didnt change anything with the test
> suite; the code is ~ tip of 2.28 release branch (plus few Gentoo-specific
> patches).
>
> The only Gentoo-specific commit which could be relevant is that we revert
> 8479f23aa1d5e5477a37f46823856bdafaedfa46 ("sysdeps/posix/getaddrinfo.c
> (gaih_inet): Only use gethostbyname4_r ..."). For the background see
> https://bugs.gentoo.org/600632
Yes, that is indeed the cause. Reverting that commit is a bit
aggressive, though. Clearly you do not need to perform dual queries if
the requested address family is AF_INET because that hasn't got any
scope IDs.
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-10 13:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 0:17 [PATCH] resolv: AAAA (28) is valid, no fallthrough to default Andreas K. Hüttel
2019-01-10 11:01 ` Florian Weimer
2019-01-10 13:47 ` Andreas K. Huettel
2019-01-10 13:51 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).