From: Florian Weimer <fw@deneb.enyo.de>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
Date: Tue, 26 Dec 2017 13:07:00 -0000 [thread overview]
Message-ID: <874lodskm6.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20171225210058.GA10404@altlinux.org> (Dmitry V. Levin's message of "Tue, 26 Dec 2017 00:00:58 +0300")
* Dmitry V. Levin:
> On Mon, Dec 25, 2017 at 12:09:56PM -0800, Zack Weinberg wrote:
>> On Mon, Dec 25, 2017 at 11:12 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
>> > On Mon, Dec 25, 2017 at 07:19:44PM +0100, Florian Weimer wrote:
>> >> * Dmitry V. Levin:
>> >>
>> >> > * sysdeps/unix/sysv/linux/tst-ttyname.c (do_in_chroot_1): Skip the
>> >> > test instead of failing in case of an error returned by posix_openpt.
>> >>
>> >> I think the test failure is real in this case. I wouldn't it be?
>> >
>> > No, /dev/ptmx is intentionally missing in the environment where this test
>> > failed.
>>
>> Why?
>
> It's a restricted environment.
I don't think the glibc test suite is supposed to pass in such an
environment. If you don't provide /dev/null, /sys, or /proc to the
tests, some of them will fail as well. I still think that the current
test accurately reflects the inadequacy of your test environment.
next prev parent reply other threads:[~2017-12-26 13:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 11:48 Dmitry V. Levin
2017-12-25 18:19 ` Florian Weimer
2017-12-25 19:13 ` Dmitry V. Levin
2017-12-25 20:10 ` Zack Weinberg
2017-12-25 21:01 ` Dmitry V. Levin
2017-12-25 21:19 ` Zack Weinberg
2017-12-25 21:39 ` Dmitry V. Levin
2017-12-26 13:07 ` Florian Weimer [this message]
2017-12-26 13:53 ` Dmitry V. Levin
2017-12-26 23:07 ` Dmitry V. Levin
2018-01-01 1:30 ` Joseph Myers
2018-01-01 2:28 ` Luke Shumaker
2017-12-29 14:20 ` Florian Weimer
2017-12-29 14:49 ` Dmitry V. Levin
2018-01-02 5:19 ` [PATCH v3] tst-ttyname: skip the test if failed to become root Luke Shumaker
2017-12-30 23:09 ` Luke Shumaker
2017-12-31 0:11 ` Dmitry V. Levin
2017-12-26 14:10 Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lodskm6.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).