From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21]) by sourceware.org (Postfix) with ESMTPS id 6F0313858D39 for ; Thu, 29 Sep 2022 13:31:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F0313858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=deneb.enyo.de Received: from [172.17.203.2] (port=53197 helo=deneb.enyo.de) by albireo.enyo.de ([172.17.140.2]) with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) id 1odtd7-003K9p-Ry; Thu, 29 Sep 2022 13:31:09 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.94.2) (envelope-from ) id 1odtd7-000ESG-G3; Thu, 29 Sep 2022 15:31:09 +0200 From: Florian Weimer To: Adhemerval Zanella Netto Cc: Yu Chien Peter Lin , libc-alpha@sourceware.org, ycliang@andestech.com, dylan@andestech.com, alankao@andestech.com Subject: Re: [PATCH v2] malloc: Fix clobbered errno when getrandom failed [BZ #29624] References: <20220929111323.12670-1-peterlin@andestech.com> Date: Thu, 29 Sep 2022 15:31:09 +0200 In-Reply-To: (Adhemerval Zanella Netto's message of "Thu, 29 Sep 2022 08:39:25 -0300") Message-ID: <875yh671eq.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: > diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h > index a263d294b1..00ab75a405 100644 > --- a/sysdeps/unix/sysv/linux/not-cancel.h > +++ b/sysdeps/unix/sysv/linux/not-cancel.h > @@ -71,7 +71,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt) > static inline int > __getrandom_nocancel (void *buf, size_t buflen, unsigned int flags) > { > - return INLINE_SYSCALL_CALL (getrandom, buf, buflen, flags); > + return INTERNAL_SYSCALL_CALL (getrandom, buf, buflen, flags); > } > > static inline int Doesn't this need a matching change to sysdeps/mach/hurd/not-cancel.h?