From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 553363858C20 for ; Mon, 22 Aug 2022 09:08:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 553363858C20 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-507-Vn0gpSv6Nae9LFaoiGw4cA-1; Mon, 22 Aug 2022 05:08:43 -0400 X-MC-Unique: Vn0gpSv6Nae9LFaoiGw4cA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 283348115B1; Mon, 22 Aug 2022 09:08:43 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.199]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F6A3492C3B; Mon, 22 Aug 2022 09:08:42 +0000 (UTC) From: Florian Weimer To: Joseph Myers Cc: Subject: Re: Add AGROUP from Linux 5.19 to sys/acct.h, remove Alpha version (bug 29502) References: Date: Mon, 22 Aug 2022 11:08:40 +0200 In-Reply-To: (Joseph Myers's message of "Wed, 17 Aug 2022 18:27:35 +0000") Message-ID: <875yik4pd3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2022 09:08:46 -0000 * Joseph Myers: > Linux 5.19 adds a new accounting flag AGROUP; add it to the > enumeration in sys/acct.h. > > This shows up that the Alpha-specific variant of this header has a > different set of constants and struct acct, which appear to be the > constants and structure layout from Linux 2.0. These were changed > some time between Linux 2.0 and Linux 2.2; I see no evidence of an > Alpha-specific layout or set of constants, but haven't checked the > detailed Linux kernel history between those versions. Rather, it > looks like tha Alpha-specific header was originally needed because of > the use of types in the kernel structure (such as uid_t and gid_t) > that had different sizes on Alpha, and when glibc was updated for > changes to the structure and constants in the kernel > > 1998-10-02 Andreas Jaeger > > * sysdeps/unix/sysv/linux/sys/acct.h: Bring in sync with current > linux 2.1 version. > > that simply omitted to do anything about the Alpha version. > > Thus, remove the Alpha version in order to get the updated definitions > into use on Alpha, as I don't think the interfaces are actually > different for Alpha with any kernel version supported by glibc. > > Tested for x86_64, and with build-many-glibcs.py for alpha-linux-gnu. Constant matches kernel. Alpha change looks okay to me. Reviewed-by: Florian Weimer Thanks, Florian