From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AE2C73858C83 for ; Fri, 19 Aug 2022 14:54:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE2C73858C83 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-AGgnYtA6PlSUdupQtVWxLg-1; Fri, 19 Aug 2022 10:54:49 -0400 X-MC-Unique: AGgnYtA6PlSUdupQtVWxLg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CFB101C13945; Fri, 19 Aug 2022 14:54:48 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 449242166B26; Fri, 19 Aug 2022 14:54:48 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 02/13] resolv: Add tst-resolv-aliases References: <151a8d509088c5189e208b27be7ac51abb4ab456.1660123636.git.fweimer@redhat.com> <9dc19001-b490-07f6-e18d-717b08968ec1@gotplt.org> <87fshs1fid.fsf@oldenburg.str.redhat.com> Date: Fri, 19 Aug 2022 16:54:46 +0200 In-Reply-To: (Siddhesh Poyarekar's message of "Fri, 19 Aug 2022 10:27:28 -0400") Message-ID: <875yio1dxl.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, INDUSTRIAL_BODY, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 14:54:51 -0000 * Siddhesh Poyarekar: > On 2022-08-19 10:20, Florian Weimer wrote: >>> Why not consolidate this with the implementation in tst-resolv-byaddr? >> The meat of the test is different, I think (gethostbyaddr vs >> gethostbyname). Only the scaffolding will overlap, and the response >> function gets more complicated. >> Or do you mean create a separate header file with just this static >> variable and function? > > Yes, this. Okay, will fix in a v2. Thanks, Florian