From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 50F2F3858401 for ; Wed, 10 Aug 2022 09:18:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 50F2F3858401 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-G_JdBw-NPH25Oh7hCO25pA-1; Wed, 10 Aug 2022 05:18:10 -0400 X-MC-Unique: G_JdBw-NPH25Oh7hCO25pA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60079801585; Wed, 10 Aug 2022 09:18:10 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.75]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98DCB40315E; Wed, 10 Aug 2022 09:18:09 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] linux: Make tst-mount-consts unsupported for kernels headers older than 5.0 References: <20220809172215.593850-1-adhemerval.zanella@linaro.org> Date: Wed, 10 Aug 2022 11:18:07 +0200 In-Reply-To: <20220809172215.593850-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 9 Aug 2022 14:22:15 -0300") Message-ID: <875yj0fods.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 09:18:13 -0000 * Adhemerval Zanella: > The linux/mount.h is only provided by Linux 5.0. > > Checked on x86_64-linux-gnu. > --- > sysdeps/unix/sysv/linux/tst-mount-consts.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sysdeps/unix/sysv/linux/tst-mount-consts.py b/sysdeps/unix/sysv/linux/tst-mount-consts.py > index 4fb356310b..0f5b982430 100755 > --- a/sysdeps/unix/sysv/linux/tst-mount-consts.py > +++ b/sysdeps/unix/sysv/linux/tst-mount-consts.py > @@ -34,6 +34,9 @@ def main(): > args = parser.parse_args() > > linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc) > + # Linux started to provide mount.h with 5.0. > + if linux_version_headers < (5, 0): > + sys.exit (77) > # Constants in glibc were updated to match Linux v5.19. When glibc > # constants are updated this value should be updated to match the > # released kernel version from which the constants were taken. Should this use compile_c_snippet from the other patch? Thanks, Florian