From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id EECDF3847804 for ; Wed, 7 Jul 2021 12:44:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EECDF3847804 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-JAFemv6ENRCKtcifQpDa-g-1; Wed, 07 Jul 2021 08:44:55 -0400 X-MC-Unique: JAFemv6ENRCKtcifQpDa-g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E62C4100A44C; Wed, 7 Jul 2021 12:44:53 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17F4410023AB; Wed, 7 Jul 2021 12:44:52 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 0/4] GLIBC_PRIVATE ABI cleanups References: <20210707105654.GM14854@arm.com> <8735sq9ygr.fsf@oldenburg.str.redhat.com> <20210707115354.GN14854@arm.com> Date: Wed, 07 Jul 2021 14:44:51 +0200 In-Reply-To: <20210707115354.GN14854@arm.com> (Szabolcs Nagy's message of "Wed, 7 Jul 2021 12:53:56 +0100") Message-ID: <875yxm8f98.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 12:44:58 -0000 * Szabolcs Nagy: > The 07/07/2021 13:04, Florian Weimer wrote: >> * Szabolcs Nagy: >> >> Florian Weimer (4): >> >> nptl: Use internal low-level lock type for !IS_IN (libc) >> >> nptl: Remove GLIBC_2.34 versions of __pthread_mutex_lock, >> >> __pthread_mutex_unlock >> >> nptl: Reduce the GLIBC_PRIVATE ABI >> >> elf: Clean up GLIBC_PRIVATE exports of internal libdl symbols >> > >> > after these commits on arm i see >> > >> > /usr/bin/ld: /work/glibc-armhf-linux/build/build/nis/libnsl_pic.a(ypclnt.os): in function `__GI_yp_unbind': >> > /work/glibc-armhf-linux/build/glibc/nis/ypclnt.c:267: undefined reference to `__libc_do_syscall' >> > /usr/bin/ld: /work/glibc-armhf-linux/build/build/nis/libnsl_pic.a(ypclnt.os): in function `__GI_yp_get_default_domain': >> > /work/glibc-armhf-linux/build/glibc/nis/ypclnt.c:415: undefined reference to `__libc_do_syscall' >> > /usr/bin/ld: /work/glibc-armhf-linux/build/build/nis/libnsl_pic.a(ypclnt.os): in function `do_ypcall': >> > /work/glibc-armhf-linux/build/glibc/nis/ypclnt.c:332: undefined reference to `__libc_do_syscall' >> > /usr/bin/ld: /work/glibc-armhf-linux/build/glibc/nis/ypclnt.c:319: undefined reference to `__libc_do_syscall' >> > /usr/bin/ld: /work/glibc-armhf-linux/build/build/nis/libnsl_pic.a(nis_call.os): in function `get_ckey': >> > /work/glibc-armhf-linux/build/glibc/nis/nis_call.c:177: undefined reference to `__libc_do_syscall' >> > /usr/bin/ld: /work/glibc-armhf-linux/build/build/nis/libnsl_pic.a(nis_call.os):/work/glibc-armhf-linux/build/glibc/nis/nis_call.c:177: more undefined references to `__libc_do_syscall' follow >> > collect2: error: ld returned 1 exit status >> >> I did build this on arm-linux-gnueabihf with build-many-glibcs.py, so >> this is very surprising. Looking at >> sysdeps/unix/sysv/linux/arm/sysdep.h, I wonder if you are building in >> thumb mode, and if so, why this isn't covered by build-many-glibcs.py. >> >> Is the comment about the r7 register still accurate? > > yes it seems the compiler defaults to thumb mode: How would one select that in a glibc build? Configure with CC="gcc -mthumb" CXX="g++ -mthumb"? If yes, then we should change at least one of the Arm targets to use that. Thanks, Florian