From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 41C1C385742C for ; Sun, 27 Jun 2021 20:14:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41C1C385742C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-602-IQL-EBc_M4WKR4sWCj0haA-1; Sun, 27 Jun 2021 16:14:16 -0400 X-MC-Unique: IQL-EBc_M4WKR4sWCj0haA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A05D8362F9 for ; Sun, 27 Jun 2021 20:14:15 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C974710016FE; Sun, 27 Jun 2021 20:14:11 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell via Libc-alpha Subject: Re: One test per line, one source per line, etc. etc. etc. References: Date: Sun, 27 Jun 2021 22:14:09 +0200 In-Reply-To: (Carlos O'Donell via Libc-alpha's message of "Sun, 27 Jun 2021 15:58:02 -0400") Message-ID: <875yxz12we.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jun 2021 20:14:19 -0000 * Carlos O'Donell via Libc-alpha: > Do we have consensus for someone to just cleanup all the makefiles > to have one source per line, one test per line etc.? I think there was some opposition to trailing \ in lists in Makefiles. This: routines += \ read \ write \ vs: routines += \ read \ write > The more reviews I do, the more this causes my to stumble and have > to work through merge issues. > > If I want to get to 100 patches reviewed per day I think this is going > to block me. Avoid merge conflicts also needs a custom merger (easier if the data is in separate files with a more regular file). Sorting the lists lexicographically avoids conflicts only stochastically, for sufficiently long lists. Thanks, Florian