From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 2C79D3896838 for ; Mon, 12 Apr 2021 08:28:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C79D3896838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FJhhs11YLz1qt3n; Mon, 12 Apr 2021 10:28:45 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FJhhs0bX5z1qry4; Mon, 12 Apr 2021 10:28:45 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id FNe_7HUSTGCi; Mon, 12 Apr 2021 10:28:44 +0200 (CEST) X-Auth-Info: v16O5/qWPGss7JxcApSZqkqglkTq8iI+/LKpwGNreJpLX0dW+mHUhufPxjgwdD6Q Received: from igel.home (ppp-46-244-166-146.dynamic.mnet-online.de [46.244.166.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 12 Apr 2021 10:28:44 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id D01792C362E; Mon, 12 Apr 2021 10:28:43 +0200 (CEST) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v3 3/4] linux: Normalize and return timeout on select (BZ #27651) References: <20210409155346.1357023-1-adhemerval.zanella@linaro.org> <20210409155346.1357023-3-adhemerval.zanella@linaro.org> X-Yow: Let's send the Russians defective lifestyle accessories! Date: Mon, 12 Apr 2021 10:28:43 +0200 In-Reply-To: <20210409155346.1357023-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 9 Apr 2021 12:53:45 -0300") Message-ID: <875z0r9a9w.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 08:28:47 -0000 On Apr 09 2021, Adhemerval Zanella via Libc-alpha wrote: > @@ -52,10 +74,13 @@ __select64 (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, > (though the pselect() glibc call suppresses this behavior). > Since select() on Linux has the same behavior as the pselect6 > syscall, we update the timeout here. */ > - if (r == 0 || errno != ENOSYS) > + if (r >= 0 || errno != ENOSYS) > { > if (timeout != NULL) > - TIMEVAL_TO_TIMESPEC (timeout, &ts64); > + { > + timeout->tv_sec = ts64.tv_sec; > + timeout->tv_usec = ts64.tv_nsec / NSEC_PER_USEC; > + } What's wrong with TIMESPEC_TO_TIMEVAL? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."